Issue 2216: Non-English Locale breaks git-review
Status:  Invalid
Owner: ----
Closed:  Oct 2013
Reported by peter.tr...@gmail.com, Oct 28, 2013
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: 1.23

What steps will reproduce the problem?
1. Use a Computer with a german Locale
2. checkout a new Project
3. Call git review -s for the first time

git-review wants to copy the commit-msg file and for that it tries to parse the output of "git remote show -n origin", but unfortunately this is localized and it does not parse.

Actual output:
ptriller@ptriller:~/projects/test$ /usr/local/bin/git-review
Problems encountered installing commit-msg hook
The following command failed with exit code 1
    "scp  :hooks/commit-msg .git/hooks/commit-msg"
-----------------------
.git/hooks/commit-msg: No such file or directory
-----------------------
ptriller@ptriller:~/projects/test$ /usr/local/bin/git-review -v
2013-10-28 13:53:03.575784 Running: git log --color=never --oneline HEAD^1..HEAD
2013-10-28 13:53:03.580384 Running: git remote
2013-10-28 13:53:03.584079 Running: git branch -a --color=never
2013-10-28 13:53:03.588014 Running: git rev-parse --show-toplevel --git-dir
2013-10-28 13:53:03.591776 Running: git remote show -n origin
Found origin Push URL: 
Fetching commit hook from: scp://:None
2013-10-28 13:53:03.596448 Running: scp  :hooks/commit-msg .git/hooks/commit-msg
Problems encountered installing commit-msg hook
The following command failed with exit code 1
    "scp  :hooks/commit-msg .git/hooks/commit-msg"
-----------------------
.git/hooks/commit-msg: No such file or directory
-----------------------

Proof that the locale is the Problem:
xxx@xxx:~/projects/test$ LANG=C git review -s -vvvvvvvvvv
2013-10-28 13:56:30.049682 Running: git log --color=never --oneline HEAD^1..HEAD
2013-10-28 13:56:30.053812 Running: git remote
2013-10-28 13:56:30.057266 Running: git branch -a --color=never
2013-10-28 13:56:30.060798 Running: git rev-parse --show-toplevel --git-dir
2013-10-28 13:56:30.064441 Running: git remote show -n origin
Found origin Push URL: ssh://ptriller@hostname:2222/test
Fetching commit hook from: scp://hostname:2222
2013-10-28 13:56:30.069133 Running: scp -P 2222 ptriller@hostname:hooks/commit-msg .git/hooks/commit-msg


Oct 28, 2013
Project Member #1 edwin.ke...@gmail.com
git-review is not part of the Gerrit Code Review Project and hence this is not the correct place to report issues with it. Please contact the maintainer of git-review [1].

[1] http://www.mediawiki.org/wiki/Gerrit/git-review
Status: Invalid