Issue 2072: ChangeScreen2: PatchSets that have unpublished draft comments should be highlighted
Status:  Released
Owner: ----
Closed:  Oct 2013
Project Member Reported by edwin.ke...@gmail.com, Aug 21, 2013
It should be easy to see if a patch set has unpublished draft comments since the user eventually wants to publish them.
Aug 21, 2013
Project Member #1 edwin.ke...@gmail.com
Shawn:
"The current revision list on ChangeScreen2 is a hack and needs to be
replaced. I am not happy with it.

The draft comment issue on prior revisions: we should consider a
behavior change where all drafts from all revisions are published at
once when you send a reply. These would then all appear together in
the same email."
Aug 21, 2013
Project Member #2 edwin.ke...@gmail.com
> Shawn:
> "The current revision list on ChangeScreen2 is a hack and needs to be
> replaced. I am not happy with it.
> 
> The draft comment issue on prior revisions: we should consider a
> behavior change where all drafts from all revisions are published at
> once when you send a reply. These would then all appear together in
> the same email."
David Pursehouse:
"Not sure I agree here.

I often add draft comments on older patch sets as reminders to myself. Having them automatically published when I comment on a newer patch set would be annoying.

I can also see this causing confusion.  The comments on older patch sets may not be relevant any more, but if they're all included in the same email they'd need to be clearly separated from comments on the current patch."
Aug 21, 2013
Project Member #3 edwin.ke...@gmail.com
> The draft comment issue on prior revisions: we should consider a
> behavior change where all drafts from all revisions are published at
> once when you send a reply. These would then all appear together in
> the same email.
+1 I'm in favour of this proposal
Oct 1, 2013
Project Member #5 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.8
Dec 9, 2013
Project Member #6 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Jul 3, 2014
#7 oswald.b...@gmx.de
not sure whether i'm just blind or something changed again in the meanwhile, but in gerrit's own instance (2.9-rc2) i cannot see any indication of draft comments in the non-current patch sets.
Jul 3, 2014
Project Member #8 edwin.ke...@gmail.com
It's shown in the patch set drop down box:
  https://gerrit-review.googlesource.com/Documentation/user-review-ui.html#patch-sets
Jul 3, 2014
#9 oswald.b...@gmx.de
not for me.

what's more, has:draft apparently doesn't any more list changes which are already closed (it does work if one explicitly adds status:closed, but that's entirely counter-intuitive behavior).