Issue 2056: Open changes do not display cutom NoOp category score
Status:  Released
Owner: ----
Closed:  Aug 2013
Reported by pravinse...@gmail.com, Aug 14, 2013
Affected Version: 2.6, 2.7

What steps will reproduce the problem?
1. Create a category (C1) of type NoOp with limits [-1, +1]
2. Give a score to an open change for C1  
3. Open changes on All --> Open or My --> Changes do not display the score given in Step 2

What is the expected output? What do you see instead?
Expected output should have been to display a cross/tick for corresponding score of -1/+1.

1. Change detail screen displays the score properly.
2. Merged and Abandoned changes display the same score differently e.g. For a score of -1/+1, Merged change will display a -1/+1 whereas an Abandoned change displays the same score as "x"/"tick mark"

Aug 15, 2013
Project Member #2 bruce.zu@sonymobile.com
for "2. .... Merged change will display a -1/+1 ...." I am adding another patchset
Aug 16, 2013
#3 pravinse...@gmail.com
Thanks

Uploaded https://gerrit-review.googlesource.com/#/c/48760/ which tries to utilize common code for open, merged, abandoned changes. Currently, the code is duplicated for open and closed changes.

Besides, I think the display should be consistent on summary and change detail screen. Even if summary screen displays a "-1"/"+1" for minimum score in NoOp category, the change detail screen displays cross/tick for the same score.
Aug 16, 2013
Project Member #4 bruce.zu@sonymobile.com
oh, collision, before getting back here, I just pushed a smaller one to stable-2.6 for fixing "2. .... Merged change will display a -1/+1 ....". https://gerrit-review.googlesource.com/#/c/48872/
 
suggest pushing 48760 to stable-2.6 too, so that users planning to run 2.6 version like my company will enjoy it. If 48760 is merged firstly I would like discard 48230 and  48872.
Good luck.
Aug 16, 2013
#5 pravinse...@gmail.com
The change I uploaded was actually fixed on 2.6.1 and then cherry-picked onto the latest code-base (without any conflicts :)). If the change 48760 gets a +1, I can then push the same change for review to stable-2.6.
Aug 21, 2013
Project Member #6 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/#/c/48907/
Status: Submitted
Labels: FixedIn-2.6.2
Dec 9, 2013
Project Member #7 david.pu...@sonymobile.com
(No comment was entered for this change.)
Labels: -FixedIn-2.6.2 FixedIn-2.8
Dec 9, 2013
Project Member #8 david.pu...@sonymobile.com
(No comment was entered for this change.)
Labels: -FixedIn-2.8 FixedIn-2.7
Dec 9, 2013
Project Member #9 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released