Issue 1987: Avatars make pointless request when no avatar installed
Status:  ChangeUnderReview
Owner: ----
Cc:
Project Member Reported by choro...@wikimedia.org, Jul 1, 2013
Affected Version: 2.7-rc2 (and 2.6 as well)

What steps will reproduce the problem?
1. Install Gerrit with no plugins
2. Observe 404 requests in debug tools for /accounts/self/avatar?s=N

Please provide any additional information below.
I think that we shouldn't make the requests if no plugin is installed. Generally these 404s are harmless, but on someone with a slow connection it's an extra round-trip or two they don't need to make.
Jul 1, 2013
Project Member #1 choro...@wikimedia.org
(No comment was entered for this change.)
Cc: bklarson@gmail.com
Jul 1, 2013
Project Member #2 bklarson@gmail.com
The alternative is adding another round-trip to check if an avatar plugin is installed... that'd be fine with me, right now we only show the avatar image in a couple places, but once (if) we show other avatars in code comments and whatnot it would make much more sense to avoid all the 404s.
Jul 4, 2013
Project Member #3 edwin.ke...@gmail.com
Actually with 2.7 we already show avatars for code comments, summary comments etc. [1,2].

[1] https://gerrit-review.googlesource.com/44980
[2] https://gerrit-review.googlesource.com/44713
Jul 8, 2013
Project Member #4 edwin.ke...@gmail.com
https://gerrit-review.googlesource.com/47508
Status: ChangeUnderReview
Jul 8, 2013
Project Member #5 David.Os...@gmail.com
back ported the fix for this critical bug to 2.6.x release:

https://gerrit-review.googlesource.com/47600

User experience is substantially degraded on heavy Gerrit sites, where it is not unusual to have a lot reviewers assigned for a change. And because the amount of non cached requests is linear to amount of reviewers we get mutli seconds think time until the change screen is rendered -- making Gerrit practically unusable.