Issue 1878: Form elements do not appear if autoVerify is not set on a contributor agreement
Status:  New
Owner: ----
Reported by wayninator, Apr 19, 2013
Affected Version: 2.6

What steps will reproduce the problem?
1. Configure a contributor agreement without an autoVerify entry
2. Click on "Agreements" on the user page
3. Click on the aforementioned contributor agreement

I expect to see the agreement text along with the form elements for digitally signing, including the "I AGREE" field and submit button.

Instead, I see only the agreement text.

I'm not entirely convinced that this is a bug. Perhaps it's intended behaviour. I could, for example, include a form in my HTML file that invokes the heavy lifting on the backend. Somehow, however, I don't think that this is what is intended.

The UI code for this is found on line 278 of NewAgreementScreen.java:

    contactGroup.setVisible(
        cla.isRequireContactInformation() && cla.getAutoVerify() != null);
    finalGroup.setVisible(cla.getAutoVerify() != null);

I haven't looked any deeper into it yet, so I don't know if it's just a simple matter of just changing the logic to show the forms regardless of the autoVerify setting. i.e. I haven't looked yet to see how the submit behaviour considers this setting.