Issue 1745: Diff viewer hidden 1 line produces no space saving
Status:  Accepted
Owner:
Reported by yuriastrakhan, Jan 5, 2013
Affected Version:
2.4.2-2-ge9a1970

The patch diff viewer shows (skipping 1 common lines) even though there is no space savings. To keep visual distractions to minimum, I think diff should not hide less than 3, possibly 4 common lines. The blue line is a good indicator of a larger chunk of hidden code, but useless for tiny savings.
Jan 17, 2013
Project Member #1 bklarson@gmail.com
Ugh.  This was reported as https://code.google.com/p/gerrit/issues/detail?id=981 and fixed with https://gerrit-review.googlesource.com/#/c/30120/.  Looks like we've had a regression somewhere... If I get some down time I'll see if I can fix this again.
Status: Accepted
Owner: bklarson@gmail.com
Labels: -Priority-Minor Priority-Trivial
Sep 8, 2014
#2 pauldbou...@gmail.com
I just tested this on revision 6b6c8f72 (Mon Sep 8) and it correctly ignores common lines < 2.  This is a smaller threshold than suggested by @yuriastrakhan but still indicates this is no longer a bug.

Suggest closing.