Issue 159: Show the list of Approvals in the "Change submitted" email message
Status:  Released
Owner:
Closed:  Oct 2012
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by David Brown <dab@android.com> on Thu Apr 30 20:23:03 PDT 2009
Source: JIRA GERRIT-159

When a change is submitted and Gerrit sends email about it, it would be
nice for the email to mention who the reviewers were.

(I got used to this feature in the p4 world, where you can look at the R=
line in the change description.  I found this really useful.)

Right now, of course, you *can* look at email headers and use the To and
Cc lines to see who the reviewers and CCed folks were, but you have to go
to the web UI to see who actually verified and/or approved it.


So how about just adding a section near the bottom with a quick-and-dirty
"plain text" version of the Approvals section from the web UI, sort of
like this:

   Approvals:
     Fred Quintana  [Verified]
     Ken Shirriff   [Looks good to me, approved]
     Jeff Hamilton

(for change 807 for example) to see at a glance that Ken reviewed it, and
that Jeff didn't but he at least got email about it.


Yeah, I realize this'll add some clutter to these emails, but they're
usually pretty brief anyway, and if this extra info can go below the list
of files I claim it won't really get in your way...
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed May 20 19:01:37 PDT 2009
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Thu May 21 11:39:11 PDT 2009

Fixed by https://review.source.android.com/10033
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Thu May 21 11:39:11 PDT 2009

Fixed in version 2.0.13.
Status: Fixed
Sep 25, 2009
#4 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.13
Oct 25, 2012
#5 sop@google.com
(No comment was entered for this change.)
Status: Released