Issue 1585: "View Drafts" permission that would let certain accounts see other's draft changes
Status:  Submitted
Owner: ----
Closed:  Nov 2012
Reported by florent....@intersec.com, Sep 27, 2012
The same way there is a patchset-created event, it would be nice to have a draft-created (or a patchset-created with an attribyte type: draft) when a new draft change is uploaded.

This would allow draft to be automatically validated by the continuous-intregration tools.
Sep 27, 2012
Project Member #1 edwin.ke...@gmail.com
Sounds good, but it might be a problem that voting on draft changes is currently not possible.
Sep 28, 2012
Project Member #2 david.pu...@sonymobile.com
There are a couple of problems with this.

Firstly the CI user most likely won't see the patchset-created event anyway because it's only visible to the owner.  The draft-published event, fired when a draft is published, was added as a workaround for this.

Secondly, the CI user won't be allowed to add comments on the draft change unless it has been explicitly added as a reviewer.

Note that there's a change currently up for review [1] that adds a reviewer-added stream event.

[1] https://gerrit-review.googlesource.com/38133

Oct 1, 2012
#3 florent....@intersec.com
Then, if I understand well, you'll advice automatically adding the CI user to new draft changes (through a post-receive hook or something like-that) and then simply listen to reviewer-added events?
Oct 2, 2012
Project Member #4 david.pu...@sonymobile.com
Or have the CI user listen for draft-published events.

(IMHO the CI user should not be reviewing draft changes anyway - that's why they're private to the owner until published)
Oct 2, 2012
#5 florent....@intersec.com
IMPOV, the CI user is a tool that is here to help developer, so if it can provide fast feedback, the developer will be more efficient (in my use case, developers usually compile the repository with gcc 4.6 or 4.7 while we must remain compatible with gcc 4.1, the sooner a build failure on old gcc is detected the easier the fix is).

Maybe what we want is to be able to have a "View Drafts" permission that would let certain accounts see other's draft changes (I'm quite sure such a permission would be helpful for other use cases).
Oct 31, 2012
Project Member #6 david.pu...@sonymobile.com
Uploaded a change to make viewing drafts a grantable permission [1].

[1] https://gerrit-review.googlesource.com/#/c/39131/

Summary: "View Drafts" permission that would let certain accounts see other's draft changes
Status: ChangeUnderReview
Nov 13, 2012
Project Member #7 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.7
Nov 24, 2012
Project Member #8 edwin.ke...@gmail.com
(No comment was entered for this change.)
Labels: -FixedIn-2.7 FixedIn-2.6
Jan 11, 2013
Project Member #9 edwin.ke...@gmail.com
 Issue 1754  has been merged into this issue.
Jan 11, 2013
Project Member #10 choro...@wikimedia.org
 Issue 1754  has been merged into this issue.