Issue 1570: "Diff All Side-by-Side" button doesn't show diffs of all files
Status:  CannotReproduce
Owner: ----
Closed:  Nov 2014
Reported by bjorn.he...@gmail.com, Sep 19, 2012
************************************************************
***** NOTE: THIS BUG TRACKER IS FOR GERRIT CODE REVIEW *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, INTERNAL *****
***** ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.    *****
***** THOSE ISSUE BELONG IN DIFFERENT ISSUE TRACKERS!  *****
************************************************************

Affected Version: (2.1.8-pk1)

What steps will reproduce the problem?
1. View https://prodkernel-git.corp.google.com/g/#change,25515
2. Click "Diff All Side-by-Side" button

What is the expected output? What do you see instead?

Note that this changeset changes three files in addition to the commit message.  But "Diff All Side-by-Side" only opens two new tabs: one for the commit message and one for the drivers/pci/ent/ent.h change.

The diffs for drivers/pci/ent/ent_ntb.c and drivers/pci/ent/mailbox_pci_head.c are not shown.  It does work to look at those diffs with the "Side-by-Side" link next to each file.

But the "Diff All" button should include them as well.

Please provide any additional information below.
Oct 5, 2012
#1 mwald...@gilt.com
I'm also having this problem. Solutions yet?
Oct 5, 2012
#2 bhelg...@google.com
I *think* what was happening is that my pop-up blocker was blocking the new tabs.  I don't know why this changed, and I don't know why I got two new tabs instead of zero new tabs.  But after I added a pop-up exception, things seem to be working as expected.
Oct 22, 2012
#3 Flatland...@gmail.com
Observations.
1. We too see only two tabs in these circumstances; not all, and not zero as might be expected.
2. Trying the 'pop-up blocker' fix results in all the pages being opened in new windows, not tabs - not ideal!
3. Opening the same Gerrit change in Firefox works fine (all the changes open in tabs)
4. This has only recently started occurring (~3weeks?). Prior to that there also seemed to be a limit but a much larger one.  Very extensive changes would not open all of the changes in tabs, some at the bottom of the Gerrit list, were missed off.
5. The files are marked in Gerrit as 'reviewed' even when they have not been opened anywhere.

Could anyone give more details re the pop-up exception setting 'fix' - I may have set this incorrectly, I guess?
Oct 23, 2012
#4 bjorn.he...@gmail.com
I thought that turning off the pop-up blocker (AdBlock) fixed this issue, but I was wrong.  I still see diffs in new windows (not tabs).  But not always; sometimes they do show up in tabs.  I'm using Chrome Version 23.0.1271.40 beta.
Oct 25, 2012
#5 bjorn.he...@gmail.com
Another possibility: if I *middle-click* on the "Diff All Side-by-Side" button, I seem to get new tabs.  If I *left-click* on it, I get new windows.  So maybe this is just user error on my part.
Nov 15, 2014
Project Member #6 zaro0508
What i see on gerrit-review.googlesource.com is that the "open all" (new CS) opens the first change in tab and the rest in new browser windows.  I also get the same result when I click on "All side-by-side diff" (old CS).  In both cases all the changes are there to review by using the forward/back arrows on top right corner.  So I guess this feature has issues, but does show all files to review.
   
Probably unrelated but there's work on single page review, which IMO is much more useful than this pop-up mania feature: https://gerrit-review.googlesource.com/#/c/59320/


Status: CannotReproduce