Issue 149: New review notifications should say "Hello <reviewer_username>, <author_username> has requested a code review" or some such
Status:  Released
Owner:
Closed:  Oct 2012
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Mike LeBeau <mlebeau@android.com> on Mon Apr 27 11:28:32 PDT 2009
Source: JIRA GERRIT-149
Affected Version: 2.0.10

It would be nice if review emails were more specific about what they're
asking, e.g.:

Hello Bjorn Bringert,

Mike LeBeau has requested you to do a code review of change 589.

...

We noticed this because to work around GERRIT-147 we started mailing android-
search as a reviewer directly, and this sends "Bjorn Bringert has requested
that you review a change" to the entire mailing list, which is a little vague
and doesn't play nicely with cc's.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by David Brown <dab@android.com> on Thu Apr 30 13:52:56 PDT 2009

Also see http://jira.source.android.com/jira/browse/GERRIT-158 , which is
a more general request that "CCed people" shouldn't be treated like
"reviewers" (i.e. don't show them together with reviewers in the
"Approvals" list; show a separate CC list; provide UI to add a new CC.)

And on that same topic, it would also make sense for the review email to
explicitly mention the reviewers (like "Hello <reviewers>," at the top of
the message).  That'll make it much more clear if you're CCed on a change
but *not* a reviewer.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed May 20 19:21:07 PDT 2009
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Thu May 21 11:39:11 PDT 2009

Fixed in version 2.0.13.
Status: Fixed
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Thu May 21 11:39:11 PDT 2009

Fixed by https://review.source.android.com/10033
Sep 25, 2009
#5 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.13
Oct 25, 2012
#6 sop@google.com
(No comment was entered for this change.)
Status: Released