Issue 1489: rebase button set commiter to Gerrit
Status:  Released
Owner: ----
Closed:  Nov 2013
Reported by amu...@wikimedia.org, Jul 24, 2012
Affected Version:

2.4.2

What steps will reproduce the problem?
1. Create a change which has for parent an old commit and send it to git
2. Look at the patchset in the GUI, committer field should be yourself
3. Press Rebase button
4. Look at the new patchset in the GUI, committer is set to gerrit2@example.com

What is the expected output? What do you see instead?

I would expect the automatically rebased patchset to use as committer name whoever did press the rebase button.


Jul 24, 2012
#1 amu...@wikimedia.org
Design choice is explained in the commit message 06e41266a213c5d0b43382ce85721b7cd16d670a


Jul 25, 2012
#2 amu...@wikimedia.org
A similar issue happen with the revert button. The committer is set to gerrit user email too.
May 30, 2013
#3 eyal.e...@gmail.com
i don't understand this design decision, this design include a problematic flow when a commit is merged and runs a job in jenkins.

since the committer is 'gerrit2' then if a build fails in jenkins, the original commiter won't receive an email alerting him that his patch failed the build.
Aug 12, 2013
#4 rolf.geu...@gmail.com
We had the same problem here.
jenkins e-mail is sent to gerrit e-mail address instead of the user of the original patch set.
I hope this will be changed soon. Because of this we will advise our developers not to use these two functions.
Is there an easy way to deactivate the buttons?
Aug 12, 2013
#5 christia...@googlemail.com
It would be really helpful if this could be changed, or if it is debatable, adding a property in some configuration file to switch between gerrit email address in rebase commit and original committer's email address would be sufficient.
Nov 4, 2013
Project Member #6 bassem.rabil
I think this should be fixed with this change:
https://gerrit-review.googlesource.com/#/c/45733/

which has been merged within Gerrit 2.8
Nov 4, 2013
Project Member #7 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.8
Dec 9, 2013
Project Member #8 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released