Issue 142: Not all emails from Gerrit re a given change wind up in the same Gmail 'conversation'
Status:  Released
Owner: ----
Closed:  Aug 2010
Cc:
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Christopher Tate <ctate@google.com> on Wed Apr 22 17:06:58 PDT 2009
Source: JIRA GERRIT-142

In some situations, Gerrit's emails about activity on a change undergoing
review wind up looking like they're a new conversation, not a continuation of
an existing conversation.  The specific case I saw was in the following
sequence:

1. robdroid@android.com uploaded a patch set and requested review; Gerrit
assigned change # 165 and sent the following email to me as a requested
reviewer:

----- begin -----
Delivered-To: ctate@android.com
Received: by 10.229.80.209 with SMTP id u17cs656713qck;
        Tue, 14 Apr 2009 18:26:52 -0700 (PDT)
Received: by 10.142.217.17 with SMTP id p17mr3943909wfg.40.1239758812040;
        Tue, 14 Apr 2009 18:26:52 -0700 (PDT)
Return-Path: <robdroid@android.com>
Received: from smtp-out.google.com ([216.239.45.13])
        by mx.google.com with ESMTP id 32si23828173wfc.16.2009.04.14.18.26.51;
        Tue, 14 Apr 2009 18:26:52 -0700 (PDT)
Received-SPF: neutral (google.com: 216.239.45.13 is neither permitted nor
denied by best guess record for domain of robdroid@android.com) client-
ip=216.239.45.13;
Authentication-Results: mx.google.com; spf=neutral (google.com: 216.239.45.13
is neither permitted nor denied by best guess record for domain of
robdroid@android.com) smtp.mail=robdroid@android.com
Received: from zps36.corp.google.com (zps36.corp.google.com [172.25.146.36])
	by smtp-out.google.com with ESMTP id n3F1QpVo016923;
	Tue, 14 Apr 2009 18:26:51 -0700
Received: from localhost (xpb11.mtv.corp.google.com [172.25.56.75])
	by zps36.corp.google.com with ESMTP id n3F1Qn8W025989;
	Tue, 14 Apr 2009 18:26:49 -0700
Received: from xpb11.mtv.corp.google.com (localhost [127.0.0.1])
	by localhost (Postfix) with ESMTP id 69E0B1E0CC;
	Tue, 14 Apr 2009 18:26:49 -0700 (PDT)
Date: Tue, 14 Apr 2009 18:26:49 -0700 (PDT)
From: Robert Greenwalt <robdroid@android.com>
To: Christopher Tate <ctate@android.com>
Cc: Robert Greenwalt <robdroid@android.com>
Message-ID: <1877905266.1291239758809408.JavaMail.android-
git@xpb11.mtv.corp.google.com>
In-Reply-To: <gerrit.1239745787173.165@android-git.corp.google.com>
References: <gerrit.1239745787173.165@android-git.corp.google.com>
Subject: Change 165: (platform/frameworks/base) Fix runtime resource
 selection logic.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
User-Agent: Gerrit/2
Mailing-List: list gerrit-platform-frameworks-base@android-git.corp.google.com
List-Id: <gerrit-platform-frameworks-base.android-git.corp.google.com>
List-Unsubscribe: <https://android-git.corp.google.com/g/settings>
X-Gerrit-ChangeURL: <https://android-git.corp.google.com/g/165>
X-Gerrit-ChangeId: 165
X-Gerrit-MessageType: requestReview

Robert Greenwalt has requested that you review a change:

165 - Fix runtime resource selection logic.

--
To respond visit https://android-git.corp.google.com/g/165
To unsubscribe, visit https://android-git.corp.google.com/g/settings
----- end -----

2. robdroid was told in review comments to please make some alterations.
These comments wound up in the same gmail conversation.

3. robdroid uploaded a new patch set for the change, and email was again sent
to the reviewers.  Unfortunately, this email looked to Gmail like it was a new
conversation.  Here's the email:

----- begin -----

Delivered-To: ctate@android.com
Received: by 10.229.75.2 with SMTP id w2cs144346qcj;
        Wed, 22 Apr 2009 14:50:48 -0700 (PDT)
Received: by 10.100.152.12 with SMTP id z12mr334089and.51.1240437047931;
        Wed, 22 Apr 2009 14:50:47 -0700 (PDT)
Return-Path: <robdroid@android.com>
Received: from smtp-out.google.com ([216.239.45.13])
        by mx.google.com with ESMTP id d24si1105330and.1.2009.04.22.14.50.47;
        Wed, 22 Apr 2009 14:50:47 -0700 (PDT)
Received-SPF: neutral (google.com: 216.239.45.13 is neither permitted nor
denied by best guess record for domain of robdroid@android.com) client-
ip=216.239.45.13;
Authentication-Results: mx.google.com; spf=neutral (google.com: 216.239.45.13
is neither permitted nor denied by best guess record for domain of
robdroid@android.com) smtp.mail=robdroid@android.com
Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com
[172.24.198.101])
	by smtp-out.google.com with ESMTP id n3MLok0U001623;
	Wed, 22 Apr 2009 14:50:46 -0700
Received: from localhost (xpb11.mtv.corp.google.com [172.25.56.75])
	by wpaz37.hot.corp.google.com with ESMTP id n3MLoiNE016450;
	Wed, 22 Apr 2009 14:50:44 -0700
Received: from xpb11.mtv.corp.google.com (localhost [127.0.0.1])
	by localhost (Postfix) with ESMTP id EF02D1E0C1;
	Wed, 22 Apr 2009 14:50:43 -0700 (PDT)
Date: Wed, 22 Apr 2009 14:50:43 -0700 (PDT)
From: Robert Greenwalt <robdroid@android.com>
To: Robert Greenwalt <robdroid@android.com>
Cc: Christopher Tate <ctate@android.com>
Cc: Dianne Hackborn <hackbod@google.com>
Message-ID: <409087803.1971240437043884.JavaMail.android-
git@xpb11.mtv.corp.google.com>
In-Reply-To: <gerrit.1239745787173.165@android-git.corp.google.com>
References: <gerrit.1239745787173.165@android-git.corp.google.com>
Subject: Change 165: (platform/frameworks/base) Squashed commit of the
 following:
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
User-Agent: Gerrit/2
Mailing-List: list gerrit-platform-frameworks-base@android-git.corp.google.com
List-Id: <gerrit-platform-frameworks-base.android-git.corp.google.com>
List-Unsubscribe: <https://android-git.corp.google.com/g/settings>
X-Gerrit-ChangeURL: <https://android-git.corp.google.com/g/165>
X-Gerrit-ChangeId: 165
X-Gerrit-Commit: 96e20409afc720f61d0cd49bf1441f62069bd6bb
X-Gerrit-MessageType: comment

Patch Set 3: No score

OK - reinserted the optimization checks of immsi, locale, etc.

Added logic for density selection.

--
To respond visit https://android-git.corp.google.com/g/165
To unsubscribe, visit https://android-git.corp.google.com/g/settings
----- end -----
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Apr 22 17:12:03 PDT 2009

Although the message thread id remained the same, GMail assigned a new thread
because the subject was modified by the replacement patch set.

We could do three things:

1)  Store the subject at creation time and always reuse that subject on all
subsequent email, even if the commit subject changes.

2)  When the subject changes, tell you the old subject in the new subject
email, so you can go find the old thread if you care.

3)  Do nothing and blame GMail.

I think we're considering option 1 here, keeping all messages for the change
under the same subject line, no matter what happens to the change after it has
been created.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Christopher Tate <ctate@google.com> on Wed Apr 22 17:26:47 PDT 2009

Yeah, I think 1) is the approach that would make me happiest.  In particular,
it would not only play well with conversation tracking, but also with filters
-- gmail doesn't look at most header contents for purposes of filter logic.
Sep 24, 2009
#3 sop+code@google.com
(No comment was entered for this change.)
Status: Accepted
Owner: ---
Sep 24, 2009
#4 sop+code@google.com
(No comment was entered for this change.)
Cc: ct...@google.com
Aug 13, 2010
Project Member #5 mf...@codeaurora.org
I believe that the subject is now consistent, so perhaps this should be closed?
Aug 20, 2010
#6 sop@google.com
Martin's velocity templating changes fixed this.
Status: Fixed
Labels: FixedIn-2.1.6
Aug 24, 2010
#7 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Dec 15, 2010
#8 sop@google.com
(No comment was entered for this change.)
Status: Released