Issue 1394: Commenting on commit message
Status:  Submitted
Owner: ----
Closed:  Jun 2012
Project Member Reported by jaysoff...@gmail.com, May 17, 2012
Affected Version: 2.3

What steps will reproduce the problem?
1. Publish a commit
2. Try to comment on the commit message

What is the expected output? What do you see instead?

Expect to be able to comment on the commit message like was possible in 2.1.7.2. In 2.3, selection the commit message just shows "No differences" so it's no longer possible to comment on it inline. This is a regression of the functionality added by https://gerrit-review.googlesource.com/16597 (I11004eddfa7ab10e6491eedcf437771bf1e5af64).

May 17, 2012
Project Member #1 jaysoff...@gmail.com
Hmm, I'm not seeing this problem on https://gerrit-review.googlesource.com so apparently it was fixed? But I can't find the relevant commit that fixes it and it's not mentioned in the 2.4 release notes.
May 17, 2012
#2 sop@google.com
Is it possible you had a patch set compare picked that wasn't base and the message didn't have any delta relative to the prior patch set?
May 17, 2012
Project Member #3 jaysoff...@gmail.com
Nope, I've definitely got base selected.
May 17, 2012
Project Member #4 jaysoff...@gmail.com
Weird, I've only got a single change exhibiting this problem. The change is open, has a single patch set, and it's parent is merged.

I thought it might be related to the fact that it has only one patch set, but I've got other changes with only a single patch set and the differ viewer shows the commit message on those as I expect.

I can't figure out what's unique about this one change.

Hrmm.

Jun 4, 2012
Project Member #5 edwin.ke...@gmail.com
[1] fixed a bug where the diff for the commit message could not be seen if the change contained files that would lexicographically sorted appear before '/COMMIT_MSG', e.g. files like '.gitignore'. This change was cherry-picked for the upcoming 2.4.1 release [2]. If you think this is a different problem, please comment.

[1] https://gerrit-review.googlesource.com/35650
[2] https://gerrit-review.googlesource.com/35690
Status: Submitted
Labels: FixedIn-2.4.1
Jun 5, 2012
Project Member #6 jaysoff...@gmail.com
Yup, that's it. I can reproduce the issue in 2.3 by publishing a change with a commit containing such a file.