Issue 1218: Merged change was still showing up as needing review for user.
Status:  Duplicate
Merged:  issue 1139
Owner: ----
Closed:  Dec 2011
Reported by docw...@gmail.com, Dec 21, 2011
Affected Version: 2.2.1

I'm un-clear how this happened, but a user had a change that was both merged and it was showed as requiring a review.

This was bugging the user because they used the dashboard to check what needed to be reviewed and this never went away.

With the help of mfick I found the offending row in the database:

SELECT * FROM `patch_set_approvals` where account_id = 17 and change_open = "Y"

returned:

0 2011-11-23 17:26:29 Y NULL 2134 1 17 CRVW

I changed the "Y" to "N" (the change_open column) and the problem was fixed.

Notes:

I think every so often, gerrit should try to heal itself.  This is needed because it doesn't have transactions.  I suspect that tomcat was taken down mid-merge and this change wasn't saved correctly.
Dec 22, 2011
Project Member #1 edwin.ke...@gmail.com
Was the reviewer added to the change after the change was merged?

If yes, this should be the same problem as described in  issue 1139  [1], which was already fixed by change 30021 [2].

[1] https://code.google.com/p/gerrit/issues/detail?id=1139
[2] https://gerrit-review.googlesource.com/#/c/30021/
Dec 22, 2011
#2 docw...@gmail.com
How can I tell? The reviewer didn't notify me about it till a couple of days ago but it had been bugging him since October.
Dec 27, 2011
Project Member #3 edwin.ke...@gmail.com
I'm pretty sure this is a duplicate of  issue 1139 , hence closing it.
Status: Duplicate
Mergedinto: 1139