Issue 1198: Change Id's should be added automatically by gerrit if missing
Status:  WontFix
Owner: ----
Closed:  Nov 2011
Reported by lhud...@cdp.com, Nov 22, 2011
Here is my scenario, I pull changes from another git repository that does not have Change-Id's (Upstream). When I push them to refs/for/master there is a change-id missing error. If I disable the change-id requirement then they get added without. Then something happens that requires rebasing. I have to cherry-pick one change at a time and recommit it with the change id gerrit assigned.

To make this easier I'd like to see gerrit automatically add the change-id to the commit message if it generated one. This way when i pull the changes from gerrit for rebasing they have change-id's.
Nov 22, 2011
#1 lhud...@cdp.com
I suppose this causes the hash to change. Doesn't sound like something that is gonna work.
Nov 22, 2011
Project Member #2 bklarson@gmail.com
Yeah this isn't really an option because it will change the hash.  Also when you rebase your local change, you still won't have the change-id unless you download the new commit from Gerrit first.

Just curious - why are you code-reviewing changes from upstream?  The typical work-flow in this case is to bypass review and push directly to refs/heads.
Nov 22, 2011
#3 lhud...@cdp.com
yea, was a mistake to push to code review. and we had changes based on those changes. gotta keep telling people do one thing at a time
Nov 22, 2011
Project Member #4 bklarson@gmail.com
Ok, thanks. I'll close this as won't fix for now.
Status: WontFix