Issue 1162: SSH Deadlock
Status:  Released
Owner:
Closed:  May 2012
Cc:
Project Member Reported by gustaf.l...@sonyericsson.com, Oct 27, 2011
Gerrit went into a state where every third ssh-command hanged.

Version used:

commit 3ef3c7ae9be32b3fd23f33202117acf88a0ff94c
Merge: 21502ed d5a8947
Author: Shawn O. Pearce <sop@google.com>
Date:   Thu Oct 27 16:32:43 2011 -0700

    Merge "Move string utils join logic into Gerrit"

-------

Stack trace attached. Sadly the beginning is missing, and the bug is not repeatable after a restart. At least the hanging threads are visible in the stack trace.
deadlock.txt
14.9 KB   View   Download
Nov 26, 2011
#1 eneev.a@gmail.com
I also affected by this deadlock.

Version used: Gerrit 2.2.1

Full stack trace attached.

Detailed symptoms description: http://groups.google.com/group/repo-discuss/browse_thread/thread/ba180ecf165f9726
stacktrace.txt
34.2 KB   View   Download
Mar 27, 2012
#2 sami.sun...@microtask.fi
This issue is causing quite a bit of trouble on our system as well. The stack traces and symptoms description give a pretty accurate picture of the situation, which is now hitting our continuous integration... well, continuously.

At least part of the problem is that one part of the synchronization is done on the Apache Mina SSHD library, so one needs to mindful of that when synchronizing things on the Gerrit code. I'm not too familiar with the Gerrit code, and following the various callbacks all around is proving a bit tedious :P I'm wondering, though, does everything in Trampoline object (in CommandFactoryProvider) really need to run in synchronized blocks? 
May 11, 2012
#3 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Owner: cran...@google.com
Labels: FixedIn-2.5
Oct 31, 2012
Project Member #5 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released