Issue 113: Require a Signed-off-by: line in the patch
Status:  Released
Owner:
Closed:  Oct 2012
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Brian Swetland <swetland@android.com> on Fri Mar 27 19:03:34 PDT 2009
Source: JIRA GERRIT-113
Affected Version: 2.0.9

Require a Signed-off-by: line in the patch.  Do not allow submission without
one.

This is a per-project rule; e.g. the Linux kernel (and its forks) tend to
require this, while other projects may want to skip the Signed-off-by
convention.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Jun 24 18:46:15 PDT 2009

Do not allow submission, or upload (push) without SOB line?

I'm inclined towards upload... as in you can't git push without a SOB, because
the SOB is the equivalent of signing the contributor agreement which says we
have the right to redistribute the work.  In kernel land, the SOB is the
agreement of the developer's certificate of origin, which says more or less
that the code is GPL, you have the right to license it under that, and anyone
can redistribute it under the terms of the GPL.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed Jun 24 18:46:19 PDT 2009
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed Jul 01 14:33:07 PDT 2009
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Jul 01 14:34:09 PDT 2009

Fixed by https://review.source.android.com/10554
Sep 24, 2009
#5 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed Jul 01 14:34:09 PDT 2009

Fixed in version 2.0.16.
Status: Fixed
Sep 25, 2009
#6 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.16
Oct 25, 2012
#7 sop@google.com
(No comment was entered for this change.)
Status: Released