Issue 1083: Review button on a change should open the review dialog inline on the original change page instead of on a new page
Status:  Released
Owner: ----
Closed:  Jul 3
Reported by jjhel...@gmail.com, Aug 9, 2011
When clicking the Review button on a change, I'm taken to a new page that allows me to set the verify and code review numbers.

A lot of the information from the original change however is not visible on this new page, and I find often canceling the review to go back to the original change page to recall some details.  For example, I almost always need to read through other reviewers comments when adding my own comments.

I think the Review button shouldn't open a completely new page but should inline (with say AJAX) itself on the same page with the original change.

Basically, the -1+1 verified, -2+2 code review (etc.) buttons & comment editbox would just open below the Review button on the same page.
Jun 25, 2012
#1 markus.k...@gmail.com
The label of the "Review" button is also not great. It should at least be "Review..." to indicate that it opens an input form. "Review" without ellipsis means something like "set the 'Review' bit", but that's not what it does.

I had a hard time even finding a way to add a comment, since the Review button is hidden inside a patch set and doesn't look like it's allowing me to input anything.

See also  issue 592 , which requests an explicit "Reply..." button for comments.
Jul 3, 2015
Project Member #2 edwin.ke...@gmail.com
Not applicable to new change screen anymore.
Status: Released
Labels: FixedIn-2.9