| Issue 938: | Diff all side-by-side on the same page |
1 of 122
Next ›
|
| 130 people starred this issue and may be notified of changes. | Back to list |
An useful feature would be to be able to view a side-by-side diff of all files in a changeset, on the same page. Currently the side-by-side button opens a new tab for each file. Sometimes it can be better to have all files on the same page, especially when you have small diffs on a lot of files.
May 27, 2011
#1
oswald.b...@gmx.de
May 27, 2011
by extension, the "review" page should be integrated at the bottom of this combined view. and taking it yet further (to minimize the number of necessary clicks/keypresses), this complete review page would be molten into the main change page. though it may turn out to be challenging to put this inside the patch set "collapsible" without distorting the layout too much and simultaneously not wasting horizontal space.
Jun 22, 2011
our contractors are now working on this.
Sep 6, 2011
I've heard rumours that this is complete in someone's tree somewhere. Any chance those are true? I'd love to check out the work...
Nov 10, 2011
it's deployed on http://codereview.qt-project.org/ now. i'm not entirely satisfied with the details, but it works reasonably well. we'll see about the upstreaming.
Nov 10, 2011
Awesome. I'm excited about that. I'd love to help out with any additional dev on details you aren't thrilled with. (I have a project full of devs who are dying for this patch, so I'll do just about anything to help either getting it upstreamed or applied locally) Thanks for the work!
Nov 16, 2011
This patch is of great interest and importance for our uses as well. From what I can see on the qt-project.org site, the feature works reasonably well. If there is a local patch that can be applied please do not hesitate to share it with us. With what aspects were you not satisifed?
Nov 17, 2011
it's all a bit "jumpy" and the formatting looks "weird". i.e., it's only about cosmetics. i'm trying to push forward having our repository openened. actively pushing upstream is a whole different matter at all ... thank google for the wording of their CLA.
Apr 26, 2012
hi, are you still planning opening the patch?
Aug 10, 2012
Do you have any news about this feature? It is very desirable for our team.
Sep 29, 2012
Any plan to merge the patch to display all diff in single page, specified in #c12?
Mar 14, 2013
Please add this feature!
Mar 29, 2013
Does anyone know if this patch has been abandoned or if can ever be merged into the upstream code?
May 18, 2013
+1 Please add this.. opening a tab for every file in the diff is very obnoxious.
Aug 19, 2013
This is one of main things holding my team from switching over to gerrit
Feb 6, 2014
Just stating the obvious but nobody did yet: the current "workaround" for this is to read comments in your email notifications, where changes and comments for all files are comfortably displayed in one page. I often watch a commit just for the sake of receiving email notifications because otherwise things are so hard that I give up before starting.
Feb 7, 2014
Also stating the obvious, that reviewing email comments, then finding the right file's page and line number and commenting is not the same as being able to review and comment on one page.
Feb 20, 2014
https://codereview.qt-project.org/78521
Feb 20, 2014
Yay! Thanks for the improvement! This is a great change.
Feb 20, 2014
It looks like shortcut keys for navigation don't work quite right with that implementation, ie I got stuck on the commit message and couldnt skip to other files in the unified mode. Great progress though!
Apr 28, 2014
Is this available in the latest gerrit version?? would love to upgrade if its available in 2.9.1!!
Apr 28, 2014
> Is this available in the latest gerrit version?? No, otherwise this issue would have been closed.
Apr 29, 2014
Any intimation on when would it be available? which version of gerrit?
Apr 29, 2014
AFAIK nobody is currently working on this.
Jun 20, 2014
next iteration against 2.7 now in https://codereview.qt-project.org/#/admin/projects/qtqa/gerrit it's fresh and done by a not-really-expert-on-gerrit, so it's still a bit buggy ...
Jul 16, 2014
(No comment was entered for this change.)
Status:
Accepted
Aug 15, 2014
I will attempt to port the work from Qt-project to master.
Status:
Started
Owner: zaro0508
Aug 15, 2014
please add me to the review when you have it up here. note that we currently have various fixes pending (including for this functionality), so make sure to keep an eye on ismo's dashboard.
Aug 15, 2014
could you please provide a link to ismo's dashboard here so i won't lose it? draft patch has been uploaded: https://gerrit-review.googlesource.com/#/c/59320
Aug 15, 2014
just click his name in the url you linked yourself.
Aug 15, 2014
I get "User ismo.haataja@digia.com not found" which means Ismo is not a registered user on gerrit-review.googlesource.com. I think you mean his dashboard on QT? He'll need to sign up for an account on upstream so i can add him as a reviewer to the my draft change.
Aug 15, 2014
of course i meant his qt dashboard. where else would he upload fixes to the qt gerrit?
Aug 15, 2014
Thanks for working on this, zaro0508! (That was a little harsh, previous commenter.)
Aug 19, 2014
@zaro0508 Did you delete your draft patch?
Aug 19, 2014
no it's a draft, so only accessable by users on reviewers list. I just published it with 'WIP' (Work In Progress) in commit message so everyone can view. I'm hoping that the gerrit community knows the meaning of WIP :/
Aug 19, 2014
Thanks.
Dec 5, 2014
I'm very interested in this feature too. How is implementation going? I'm interested in helping.
Dec 5, 2014
Please give it a try: https://gerrit-review.googlesource.com/#/c/59320/ I believe everything works as expected and is up to date with master. The only missing functional piece right now is that it's still only available from the old change screen. I think these are the TODO items for this change: 1. Update the new change screen to link to the new single page review. I was thinking that the 'open all' button should open the single page review screen. 2. Clean up the single page review screen a little bit, just a few UI elements out of place. 3. Add some tests where necessary.
Dec 5, 2014
We have this fully working in out internal environment on both 2.9 & master from the new Change Screen, including the ability to post comments. We are preparing to sign the Android Open source Contribution agreement and this requires us go through our lawyers. This is what is holding us up from posting our patches to https://gerrit-review.googlesource.com/#/c/59320/
Dec 5, 2014
That's great! Could you please provide an ETA for us? Hmm interesting, posting comments seemed to work for me in it's current state. Was wondering what you found wrong with it?
Dec 5, 2014
I wish I could give an accurate ETA.. but I think its likely to be closer to the end of December. Re: Posting comments.. when we first started with this patch and made the changes to support the new CS, the comments functionality did not work. It took us a while to get it to work just like it does know with the old CS. We haven't been able to make the keyboard shortcuts work across files though. e.g. hitting 'n' stops at the end of the first diff box.
Mar 24, 2015
(No comment was entered for this change.)
Status:
Accepted
Owner: ---
Apr 20, 2015
I'd like to see that change as well.
Apr 22, 2015
I was informed that the proposed solution was discarded because it was based on the old change screen and refactoring to use new change screen was not worth it. It seems latest code was submitted to https://gerrit-review.googlesource.com/#/c/59320/ . I'll look at this.
Dec 26, 2015
still interested |
|
| ► Sign in to add a comment |