My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 997: Read Access granted to 'Project Owners' is not properly resolved
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  edwin.ke...@gmail.com
Closed:  Jun 2011


Sign in to add a comment
 
Project Member Reported by edwin.ke...@gmail.com, Jun 3, 2011
Affected Version: 2.1.7 and 2.2.0

What steps will reproduce the problem?
1. assign the following access rights on a project:
Read Access     Project Owners  refs/*        +1: Read access
Owner           MyGroup         refs/*        +1: Administer All Settings

2. try to clone the repository via SSH with a user that is a member of MyGroup

3. cloning the repository fails with 'not a Gerrit project', indicating that the project is not visible to the user

What is the expected output? What do you see instead?
It is expected that the user is able to clone the repository. As member of MyGroup the user is a project owner and hence the Read Access granted to the 'Project Owners' group should apply.

Please provide any additional information below.
The resolution of the 'Project Owners' group is only handled in the RefControl class, when the access rights for a concrete ref are checked. However for certain operations the ProjectControl class checks whether an access rights is granted on any ref. In this place the code is not taking access rights into account which are granted to the 'Project Owners' group.
Jun 3, 2011
Project Member #1 edwin.ke...@gmail.com
A fix has been pushed for code review:
https://review.source.android.com/23413
Jun 7, 2011
#2 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.1.7.1
Jun 7, 2011
#3 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting