| Issue 988: | Don't show repeated signed-off-by if same as author | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Gerrit shows a single signed-off-by (as the 'committer') and the author. However, if the author has self-signed-off-by the commit, Gerrit doesn't always show the 'other' signatory - in fact, it only shows the first alphabetically in all cases. http://egit.eclipse.org/r/#change,2761 commit 3a1995dbcc1fb131b2b8b5dfb54b58788a0c7df1 Author: Jens Baumgart <jens.baumgart@sap.com> Date: Thu Mar 17 19:14:15 2011 +0100 Change-Id: Ibd0e883bb6c82c42d1b3bd08743dd7d050e95291 Signed-off-by: Jens Baumgart <jens.baumgart@sap.com> Signed-off-by: Philipp Thun <philipp.thun@sap.com> However, in Gerrit's UI it shows Jens as the author and committer: Author Jens Baumgart<jens.baumgart@sap.com>Mar 17, 2011 6:14 PM Committer Jens Baumgart<jens.baumgart@sap.com>Mar 17, 2011 6:14 PM The suggestion would be to remove the author from the candidate list of signed-off-by users (or put it last in the list) so that if another is specified that is shown in preference. It appears that it's being chosen as the first alphabetic name: commit 87873cfe6aadbe1d5d043ec29e6862ade4fca6b0 Author: Stefan Lay <stefan.lay@sap.com> Date: Wed Mar 9 15:24:02 2011 +0100 Change-Id: I1728516f31822375464c8a69cd9f766f6075de2d Signed-off-by: Stefan Lay <stefan.lay@sap.com> Signed-off-by: Matthias Sohn <matthias.sohn@sap.com> And in Gerrit's UI: Author Stefan Lay<stefan.lay@sap.com>Mar 9, 2011 2:24 PM Committer Matthias Sohn<matthias.sohn@sap.com>Mar 16, 2011 1:34 PM
May 31, 2011
#1
sop@google.com
Status:
Incomplete
Jun 1, 2011
Sorry, let me try to explain again. If we have: Committer: A Signed-Off-By: A Signed-Off-By: B and Committer: B Signed-Off-By: A Signed-Off-By: B then ideally in Gerrit you'd like to show Commiter: A, Signed-Off-By: B (and Commiter: B, Signed-Off-By: A). What happens at the moment is you get the first signed-off-by alphabetically (Committer: A, Signed-Off-By: A, Commiter: B, Signed-Off-By: A). Does that make sense? The two changes linked above demonstrate this view in Gerrit. (Having looked at the code since I filed this bug, it seems that the issue might be in the JGit layer rather than Gerrit though)
Jun 1, 2011
Gerrit doesn't pull anything from the signed-off-by lines. It pulls the committer and author from the git commit object. These can be set with some flags & environment variables when running 'git commit'.
Jun 2, 2011
Gerrit won't modify the commit message. You need to modify it yourself before you upload the change for review. The Signed-off-by lines in a commit message are typically in the order the patch flows between developers. If this isn't the case in a particular project, you should talk to the project's developers/maintainers about why they are making the order something other than the order the patch flowed in.
Status:
WontFix
|
|
| ► Sign in to add a comment |