My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 981: Don't say "...skipping 1 common line..." per se; just show the line, please
3 people starred this issue and may be notified of changes. Back to list
Status:  Submitted
Owner:  bklarson@gmail.com
Closed:  Oct 2011


Sign in to add a comment
 
Reported by danf...@google.com, May 26, 2011
Affected Version: 2.1.7-rc2-26-g3739569

What steps will reproduce the problem?
1. Modify a file in two places, 22 lines apart.
2. Commit the file and upload the change.
3. View the diff of the file, side-by-side.
4. Set the context to be "10 lines."

What is the expected output? What do you see instead?

Expected: The two changes show up in a single block of lines.
Actual: The two changes show up as separate blocks of lines, with the annotation "...skipping 1 common line..." in between the two blocks.

Please provide any additional information below.

Basically, if there's only one line to skip, it doesn't save any space to replace the line with an indication it was skipped.

See attached.
perhaps-this-should-be-collapsed.png
111 KB   View   Download
May 26, 2011
#1 sop@google.com
Haha. This is a regression. We used to do what you want. :-(
Status: Accepted
Labels: Milestone-2.1.8
Oct 26, 2011
Project Member #2 bklarson@gmail.com
(No comment was entered for this change.)
Owner: bklarson@gmail.com
Labels: -Milestone-2.1.8
Oct 27, 2011
Project Member #3 bklarson@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.2.2
Sign in to add a comment

Powered by Google Project Hosting