My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 963: If 'Publish and Submit' fails on submit the comments and approvals should not be published
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  May 2011


Sign in to add a comment
 
Project Member Reported by edwin.ke...@gmail.com, May 19, 2011
Affected Version: 2.1.7-rc1

What steps will reproduce the problem?
1. Open a change that is in review
2. click on the'Review' button for the latest patch set
3. make sure that the preconditions for submit are not fullfilled (e.g. that there is no +2 Code Review)
4. click on 'Publish and Submit'
5. see that you get an error saying that submit failed
6. the comments and approvals have been published

What is the expected output? What do you see instead?
For the user the 'Publish and Submit' looks like an atomic action, so that it's expected that either both publish and submit succeed or that both of them fail.


Please provide any additional information below.
There are two independent RPC calls, one to publish the comments and approvals and one to do the submit.
May 19, 2011
Project Member #1 edwin.ke...@gmail.com
There is a change for review that makes the current behaviour more obvious to the user:
https://review.source.android.com/23015
May 19, 2011
#2 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.1.7
May 31, 2011
#3 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting