My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 957: Access panel should propose new change
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Apr 2013


Sign in to add a comment
 
Project Member Reported by sop@google.com, May 19, 2011
Instead of committing and applying the access change(s) immediately, the access panel should open a new change for the refs/meta/config branch and display it to the user. This way the user can add a reviewer and get an access modification peer-reviewed before making it live.
Apr 12, 2013
#1 krinklemail@gmail.com
Yeah, at least having the option to either "Save change" or "Propose change" would be nice.

Note you can do it manually if you clone the repository.

~ $ cd ~/Development/example
../example (master)$ git fetch gerrit refs/meta/config
../example (master)$ git checkout -b config FETCH_HEAD
../example (config)$ edit project.config groups
../example (config)$ git add -p
../example (config)$ git commit
../example (config)$ git push gerrit config:refs/for/refs/meta/config

This will create a change in Gerrit for others to review / merge.

Apr 12, 2013
#2 sop@google.com
This has been live in Gerrit UI for a while now. There is a Save for Review button on the Access tab that does exactly this process for you.
Status: Released
Apr 12, 2013
#3 krinklemail@gmail.com
I just checked this in version 2.6-rc0-322-geeed497 and this has been done.

There is now a "Save Changes" and a "Save for Review" button.
screenshot.png
233 KB   View   Download
Sign in to add a comment

Powered by Google Project Hosting