My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 926: gerrit doesn't work with IE9
12 people starred this issue and may be notified of changes. Back to list
Status:  Submitted
Owner:  ----
Closed:  Jan 2013


Sign in to add a comment
 
Reported by allenm716@gmail.com, May 3, 2011
Affected Version: 2.1.7-rc0

What steps will reproduce the problem?
1. Load gerrit 2.1.7-rc0 with IE9 (http://gerrit.chromium.org)

What is the expected output? What do you see instead?

Expect to see main gerrit page, instead see the following forever:

Loading Gerrit Code Review ...


Please provide any additional information below.

May 3, 2011
#1 allenm716@gmail.com
IE version: 9.0.8112.16421

May 5, 2011
#2 piotr.si...@gtempaccount.com
I can confirm this. However, Gerrit works with IE9's "compatibility view".
May 19, 2011
Project Member #3 nas...@grainawi.org
This should be fixed when we move to GWT 2.3.0.
https://review.source.android.com/23033
Status: Started
Oct 11, 2011
#4 adr...@foeder.de
To be specific, it throws the well known "INVALID_CHARACTER_ERR (5)" exception that is thrown when an element is attempted to be created and a string is expected (e.g. document.createElement('div') is expected, but "...createElement('<div>')" is supplied (note the angle brackets that are not valid in this context)
Oct 17, 2012
#7 zhon...@gmail.com
Not sure if this is already known but I couldn't find this anywhere else.  IE9 is still an issue in gerrit 2.4+ even though gwt 2.3.0 is being used.  The ie9 permutation is being generated but gerrit uses gwtexpui's Permutation class instead of the standard gwt *.nocache.js to handle permutation loading.  Specifically the gwtexpui's UserAgentRule class is out of date and needs ie9 (v > 9000) version checking.  

https://code.google.com/p/gerrit/source/browse/src/main/java/com/google/gwtexpui/linker/server/UserAgentRule.java?spec=svn.gwtexpui.f00998e978c067de331ff3d984d387896b62940b&repo=gwtexpui&r=f00998e978c067de331ff3d984d387896b62940b

Oct 17, 2012
Project Member #8 bklarson@gmail.com
 Issue 1530  has been merged into this issue.
Oct 30, 2012
#9 aklap...@wikimedia.org
Outcome described in  issue 1530  also happens with IE10 according to https://bugzilla.wikimedia.org/show_bug.cgi?id=41559
Jan 28, 2013
#10 Dariusz.Luksza
Does this issue still occur on latest master? GWT version was bumped to 2.5 in commit 035ac8f3c8a8c733e616e79e9f4a4cecd4778efc and IMO this should fix issues with IE9
Jan 28, 2013
#11 sop@google.com
Nope a GWT bump won't fix this. The permutation selector in our code is out of date.
Status: Accepted
Jan 29, 2013
#12 m0.inter...@gmail.com
When I used to work for RIM last year, we forked Gerrit to add more features that were missing to make developers life/gatekeepers life easier and I remember I fixed this. There were plans to upstream our fork from there, but I changed jobs so I don't know the status of that now.

By fixing the permutation selector it made it work again for IE8/9/10. It was a relatively easy fix to do. Just search for IE8 and you will see what I mean.
Jan 29, 2013
Project Member #13 edwin.ke...@gmail.com
https://gerrit-review.googlesource.com/41690
Status: ChangeUnderReview
Jan 29, 2013
#14 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.6
Sign in to add a comment

Powered by Google Project Hosting