My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 91: Delay UI update until Screen instance is ready
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Sat Feb 28 12:11:23 PST 2009
Source: JIRA GERRIT-91
Affected Version: 2.0.5

Screen widgets shouldn't be put "on screen" until after their data is ready.

Most Screen subclasses need to perform 1 or 2 RPCs in order to acquire the
data they want to display.  We shouldn't put the Screen into a visible part of
the DOM until after those RPCs are complete and the Screen subclass has had a
chance to update itself to reflect the received information.

Some Screen subclasses can take a long time to draw, like the current
PatchTable within a ChangeScreen.   The table might have a progress bar to
show its rendering status, in which case its OK to show the ChangeScreen
before that part of the UI is fully initialized.

Hyperlink widgets within the application need to be replaced to make this
work, because ideally we wouldn't want to change the current location and the
history stack until the Screen actually appears in the UI.  This is how GMail
behaves; the new history item isn't inserted until the UI is updated.

This is somewhat difficult to do at this stage because many of the Screen
widgets use their onLoad method to start RPCs, and onLoad is invoked when the
widget is put into the DOM.  We need to move the RPCs out of onLoad and put
them elsewhere.  Also all hyperlinks need to use a different method than just
setting the a href.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Tue Apr 14 09:09:04 PDT 2009

Fixed by https://review.source.android.com/9518
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Tue Apr 14 09:09:04 PDT 2009

Fixed in version 2.0.10.
Status: Fixed
Sep 25, 2009
#3 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.10
Oct 25, 2012
#4 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting