My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 900: Gerrit uses case-sensitive matching on email addresses
11 people starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Feb 2012


Sign in to add a comment
 
Reported by tsuna...@gmail.com, Apr 7, 2011
Affected Version: All up to 2.1.6.1

What steps will reproduce the problem?
1. Register on Gerrit with email foo@example.com
2. Configure your Git repo with user.email = Foo@example.com
3. Push changes to Gerrit

What is the expected output? What do you see instead?
Gerrit should accept the commits, instead it rejects them because "you are not committer Foo@example.com".

Please provide any additional information below.
 Issue #716  mentions "For simplicity reasons Gerrit just enforces that the entire email address is case sensitive and must match exactly.".  In this issue, I would like to revisit this.  Can anyone explain whether and why it would be a problem if Gerrit always lower-cased any email address it handles?  Both before inserting them into its database and before reading back from it?  I'm not really happy with people using Foo@example.com as their email address, but I don't want to make the life our users more difficult than necessary.
Apr 8, 2011
#1 nas...@chromium.org
(No comment was entered for this change.)
Status: Duplicate
Mergedinto: 321
Apr 8, 2011
#2 tsuna...@gmail.com
I actually saw  issue #321  but didn't consider it a duplicate because it was specific to the way autocompletion works, whereas here I specifically care about being to push changes regardless of the capitalization of the email.  Did you close this issue as a duplicate because you expect that  issue #321  will be resolved by lower-casing the email address before writing / reading?
Apr 8, 2011
#3 nas...@chromium.org
No, I just have reading problems. Sorry. Fixing 321 might fix this, but I don't know the part of Gerrit handling verifying the push well enough to say for sure.
Status: New
Mergedinto:
Nov 5, 2011
#4 egrumbach
Please note that sometimes the email address is coming from the LDAP server. At my site, one guy didn't understand why it wouldn't work until we actually manually check his email in LDAP using ldapsearch.

I agree that the email shouldn't be case sensitive.
Feb 14, 2012
#5 egrumbach
From what I see in [1], this issue should be closed as "not-a-bug".

[1] http://groups.google.com/group/repo-discuss/browse_thread/thread/8554577b4a145df2
Feb 14, 2012
Project Member #6 bklarson@gmail.com
Correct, Gerrit is just following the RFC.
Status: WontFix
Apr 6, 2012
Project Member #7 bklarson@gmail.com
 Issue 1321  has been merged into this issue.
Aug 8, 2014
#8 reimar.d...@gmail.com
Referring to RFC 2821 is nonsense, Gerrit does not implement SMTP, thus that specification has no relevance to it.
What instead would be relevant is the behaviour of the server receiving that person's email.
Given that Gerrit can't really query the server to figure it out, and considering that no major email server I know about enforces case sensitivity of the local part, making it configurable would be an obvious option.
I would even argue that making it the default would make sense, as it is the standard behaviour (not as part of SMTP, but of the actual email servers) and I can't see how it would cause issues to anyone, while the current behaviour is an annoyance.
Aug 8, 2014
#9 reimar.d...@gmail.com
Even RFC2821 says "However, exploiting the case sensitivity of mailbox local-parts impedes interoperability and is discouraged."
Depending on whether you consider Gerrits behaviour "exploiting case sensitivity" or not, you could even claim it does not match the recommended RFC2821 behaviour - if it was applicable at all.
Feb 10, 2015
#10 sam.mxra...@gmail.com
WontFix is a mind-numbing verdict.  Case insensitivity should at least be an option for accepting emails because email verifications for multiple cases end up in the same inbox.  Why do you subject your users to this pain?
Sign in to add a comment

Powered by Google Project Hosting