My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 878: Unable to open side-by-side review in Opera 11.01+
52 people starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Apr 2015


Sign in to add a comment
 
Reported by pchida...@gmail.com, Mar 14, 2011
Affected Version:

What steps will reproduce the problem?
1. Open any C gerrit review and try to open the side by side review for a C file in Opera 11.01+
2. Enable Java script console
3.

What is the expected output? What do you see instead?
Instead of opening the review, there is an error on console


Please provide any additional information below.

JavaScript - https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2FD338.cache.html
Unknown thread
Uncaught exception: TypeError: 'a.prettyPrintOne' is not a function
Error thrown at line 362, column 39 in XLb(a, b, c, d) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2FD338.cache.html:
return a.prettyPrintOne(b,c)
called from line 316, column 20 in VLb(a, b, c) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2FD338.cache.html:
return XLb($wnd[SLb.c],b,c,a.f.m)
called from line 540, column 139 in HLb(a, b) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2FD338.cache.html:
c=VLb(a,c,ILb(a))
called from line 431, column 103 in IGb(a) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2FD338.cache.html:
HLb(c,a.c);
called from line 548, column 48 in Vkb(a) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2FD338.cache.html:
b=IGb(a);
called from line 295, column 42 in $cb(a, b, c, d, e) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2FD338.cache.html:
a.vc(e)
called from line 541, column 533 in eib(a, b, c) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2FD338.cache.html:
$cb(a.f,a.q,a.j,a.k,b);
called from line 350, column 16 in fjb(a) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2FD338.cache.html:
this.c.u==this.e&&eib(this.c,a,this.d)
called from line 89, column 30 in eG(a) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2FD338.cache.html:
this.Qb(a);
called from line 116, column 130 in wdd(b, c, d) in https://review-android.quicinc.com/gerrit/058527BB7501D1254508D3422A2FD338.cache.html:
c.xb(g)
Mar 18, 2011
#1 pchida...@gmail.com
JavaScript - https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943A5F8.cache.html
Unknown thread
Uncaught exception: TypeError: 'a.prettyPrintOne' is not a function
Error thrown at line 378, column 39 in nMb(a, b, c, d) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943A5F8.cache.html:
    return a.prettyPrintOne(b,c)
called from line 321, column 20 in lMb(a, b, c) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943A5F8.cache.html:
    return nMb($wnd[iMb.c],b,c,a.f.m)
called from line 543, column 139 in ZLb(a, b) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943A5F8.cache.html:
    c=lMb(a,c,$Lb(a))
called from line 430, column 103 in $Gb(a) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943A5F8.cache.html:
    ZLb(c,a.c);
called from line 551, column 48 in llb(a) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943A5F8.cache.html:
    b=$Gb(a);
called from line 297, column 42 in qdb(a, b, c, d, e) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943A5F8.cache.html:
    a.wc(e)
called from line 544, column 533 in wib(a, b, c) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943A5F8.cache.html:
    qdb(a.f,a.q,a.j,a.k,b);
called from line 341, column 16 in xjb(a) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943A5F8.cache.html:
    this.c.u==this.e&&wib(this.c,a,this.d)
called from line 123, column 30 in wG(a) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943A5F8.cache.html:
    this.Rb(a);
called from line 167, column 130 in ofd(b, c, d) in https://review.source.android.com/gerrit/366DE73696967BD9C9840AD4C943A5F8.cache.html:
    c.yb(g)

Mar 23, 2011
#2 pchida...@gmail.com
Any update on this one? This is making opera unsuable at work.
Apr 25, 2011
#4 adea...@gmail.com
This is also very irritating for me (with the OpenAFS code review system). It looks like it may be a bug in GWT, but I wouldn't really know. If someone can provide some details that I could use to file a bug with them, I certainly wouldn't mind pursuing it.

Some kind of option to turn off the code highlighting would also be appreciated, to work around this, which seems like it would be much easier. I assume this issue would go away if we don't try syntax-highlighting on the code. Were it not for email notifications, right now I wouldn't be able to read inline comments at all without using a different browser.
May 20, 2011
Project Member #5 nas...@grainawi.org
We'll be upgrading to GWT 2.3 for the Gerrit 2.2.0 release and that seems to fix this issue.
https://review.source.android.com/23070
Status: Started
Labels: Browser-Opera Milestone-2.2.0
Jun 22, 2011
#6 auke.sch...@gmail.com
It looks like this isn't fixed in GWT 2.3 / Gerrit 2.2.1. Andriod uses Gerrit 2.2.1-57-g4efeb4f and egit uses 2.2.1-67-g17ca55f and both sites throw the TypeError ('b.prettyPrintOne' is not a function) in Opera 11.11 (OS X).
Jun 26, 2011
#7 pchida...@gmail.com
I concur Android Gerrit 2.2.1 doesnt seem to fix this issue. I recollect that this used to work on Opera 10 even when Opera 11 did not work. I have tried pursuing this with opera devs. They dont seem to pay much heed. I am looking to see if anybody can provide a work around. I think in Opera this can be done with a local javascript that will provide the prettyPrintOne function override, but I dont have the know hows of how to get it in there.
Jun 26, 2011
#8 pchida...@gmail.com
I concur Android Gerrit 2.2.1 doesnt seem to fix this issue. I recollect that this used to work on Opera 10 even when Opera 11 did not work. I have tried pursuing this with opera devs. They dont seem to pay much heed. I am looking to see if anybody can provide a work around. I think in Opera this can be done with a local javascript that will provide the prettyPrintOne function override, but I dont have the know hows of how to get it in there.
Jul 25, 2011
#9 kay.stro...@gmail.com
sometimes same for chrome or firefox
Jul 27, 2011
#10 Hade...@gmail.com
If you have reported it for Opera, what bug tracking N° would that be?
Jul 27, 2011
#11 pchida...@gmail.com
Opera bug DSK-326948
Apr 18, 2012
#12 a.d.be...@gmail.com
Why should that be an Opera bug? If a function is not defined, that's gerrits fault.
Apr 19, 2012
#13 auke.sch...@gmail.com
I think it's a bug in Opera because Opera 11.00 works fine and the error occurs first in Opera 11.01 and is still there in Opera 11.62 and Opera Next (12.00).

I reported it to Opera again (DSK-358177, 2012/02/24) but unfortunately there is no response on the bug report.

Does somebody have a clear picture of what is causing the missing function? Has anyone tried a workaround with Opera user javascript?
Apr 20, 2012
Project Member #14 bklarson@gmail.com
 Issue 1341  has been merged into this issue.
May 3, 2012
#15 adea...@gmail.com
> Has anyone tried a workaround with Opera user javascript?

This can be worked around if syntax highlighting is disabled. Before, I wasn't aware that this was even possible, but it is possible to disable in the side-by-side or unified review interface. Since that interface doesn't load due to this bug in the first place, I've found two ways to disable it:

1. Open the commit message in side-by-side or unified view. This requires some version of gerrit or something, I'm sure. Viewing the commit message in these views doesn't fail for me.

2. Open a source file in side-by-side or unified view in Firefox, or another browser that doesn't encounter this problem.

From there, you can deselect the "Syntax Coloring" checkbox near the top, and then click the "Update" button. After that is done, viewing any file in the side-by-side or unified view works for me.

I'm sure that setting won't be retained if you're not logged in and move between machines, etc. It's also possible to force this off with user javascript, but by the time I figured that out I realized it wasn't necessary :)

I'm still trying to look into the real problem when I can, but this appears to be a usable workaround for me in the meantime.
May 15, 2012
#16 nitzan...@gmail.com
the workaround above does work. what does the Opera team need to know? we should all report it. maybe it'll get the dev team's attention then.
Jun 16, 2012
#17 jocula...@gmail.com
Disabling the syntax highlighting works for me
Opera 12.0 AM64 on xUbuntu 12.04

Anyone tried to define user.js with prettyPrintOne()? Why it fails?
Jul 25, 2012
Project Member #18 choro...@wikimedia.org
 Issue 1009  has been merged into this issue.
Oct 18, 2012
Project Member #19 bklarson@gmail.com
 Issue 1616  has been merged into this issue.
Oct 18, 2012
#20 daniel.w...@wikimedia.de
A simple fix for this would be great. Why not simply check for the Opera version and disable the Syntax highlighting?
Oct 21, 2012
Project Member #21 bklarson@gmail.com
 Issue 1617  has been merged into this issue.
Feb 19, 2013
#22 aklap...@wikimedia.org
Still valid in Opera 12.13, tested on gerrit.wikimedia.org.
Jun 11, 2013
#23 grel...@gmail.com
Still present in Opera 12.15, tested against Gerrit 2.5.

The procedure for the workaround seems to have changed slightly: you now need to click the 'preferences' link in the header while reviewing a file to show the review preferences, then disable syntax highlighting as in comment 15.
Oct 11, 2013
Project Member #24 dougk....@gmail.com
I can confirm that this is an issue with Opera 12.16 / Gerrit 2.4.2 and master, but Opera 17 works fine with both 2.4.2 and master.  The issue does appear to be specific to Prettify, and CodeMirror (included with ChangeScreen2 on master) appears to work fine as well on both versions of Opera.

Maybe something worth reporting back to the Prettify project?
Oct 12, 2013
#25 daniel.w...@wikimedia.de
Opera 15+ probably all work fine since they are now using WebKit. The thing is that Opera 17 lacks so many functions of Opera 12 that you can see Opera 15+ as entirely different browser right now. So this should still be fixed for Opera 12.
Apr 29, 2015
Project Member #26 edwin.ke...@gmail.com
Uh, this is pretty old. Is this still an issue with recent Gerrit and Opera versions?
Status: New
Labels: -Milestone-2.2.0
Apr 29, 2015
#27 semenik@gmail.com
No, modern Opera is just a reskinned Chrome. Recommend losing this bug as not actual anymore, and RIP Presto:(
Apr 29, 2015
#28 jarno.ma...@vincit.fi
Opera 12 hasn't been updated in a long time. With todays development speed of web sites and frameworks, I believe many of "us" old Opera users have already transferred to other browsers like the new Opera or Vivaldi. No issues with those.
Apr 29, 2015
Project Member #29 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: WontFix
Sign in to add a comment

Powered by Google Project Hosting