| Issue 862: | UI: "Review and Submit" can lead to confusing error | |
| 18 people starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.1.6.1 What steps will reproduce the problem? 1. Review a new, unreviewed, patch set. 2. Set Code Review to +2 3. Do NOT set verify (leave at 0). 4. Click "Review and Submit". You get an application error saying you don't have permission to submit. What is the expected output? What do you see instead? It should either: 1. Display a helpful message explaining they can only review, not review and submit. 2. Disable the 'review and submit' button unless someone has verified. Please provide any additional information below.
May 20, 2011
Project Member
#1
nas...@grainawi.org
Status:
Accepted
Feb 27, 2012
Seems like both would work well, a disabled button and a tool-tip or small text box explaining why it's disabled.
Feb 27, 2012
version: b917a2ac5a6b88210d3d044a894bf394c1195a59 test and get feedback: ----------------------------------------- Application Error Server Error Cannot submit <change Id>:needs Verified ----------------------------------------- I think we just need to remove 'Application Error'
Jan 19, 2015
No longer relevant after migration to the new change screen.
Status:
WontFix
|
|
| ► Sign in to add a comment |