My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 86: ie6: Back button is partially broken
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Wed Feb 25 08:10:11 PST 2009
Source: JIRA GERRIT-86
Affected Version: 2.0.5

Back button is partially broken.  Sometimes it works, sometimes it doesn't.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Feb 25 08:20:17 PST 2009

I think this has to do with History.newItem not working correctly.

If we use a real hyperlink where the browser navigates on its own to a new
anchor (e.g. the HTML was actually <a href="#foo"> with no onclick magic) the
back button works.  See for example the Prev/Next links on the all changes
page (#all,open,n,z), these work correctly.

If we use a History.newItem call, I see a flash of a JavaScript error, the
entire page reloads, and the content displays.  And the back button doesn't
work.  See for example clicking on a file name in a Patch Set on any change.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed Feb 25 09:12:26 PST 2009
Labels: -Priority-Major Priority-Trivial
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed Feb 25 09:13:17 PST 2009
Labels: -Priority-Trivial Priority-Minor
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Sat Feb 28 12:13:24 PST 2009

I think my earlier comment about this issue is wrong.

Links which use the GWT Hyperlink widget work correctly, the Back button knows
what the prior page was and can go back.

Links which are bare HTML, e.g. just an '<a href="#...">' such as those
created by the PatchSetTable (it renders using pure HTML) don't call into the
GWT History class and result in the Back button failing.
Sep 24, 2009
#5 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Sat May 16 15:17:32 PDT 2009
Sep 24, 2009
#6 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Sat May 16 15:44:28 PDT 2009

Fixed by https://review.source.android.com/9960
Sep 24, 2009
#7 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Sat May 16 15:44:28 PDT 2009

Fixed in version 2.0.12.
Status: Fixed
Sep 25, 2009
#8 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.12
Oct 25, 2012
#9 sop@google.com
(No comment was entered for this change.)
Status: Released
Blocking: -gerrit:84
Sign in to add a comment

Powered by Google Project Hosting