| Issue 846: | RPC calling buttons should be disabled during RPCs | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Affected Version: Gerrit 2.1.6 What steps will reproduce the problem? 1. Review a change on a slow link (say using VNC) 2. Enter a comment 3. Press 'Publish Comments" 4. Press 'Publish Comments" again What is the expected output? What do you see instead? I would expect it to not be able to hit "Publish Comments" twice. Instead, the button is still "enabled" and allows a second publish to happen, publishing the same comments twice. Please provide any additional information below. Generally speaking it seems like any button which fires off an RPC and for which the action should not be done twice in a row, should be disabled at least for the duration of the RPC. I suggest a small code audit to look for other such potentially problematic cases.
Feb 15, 2011
Project Member
#1
mf...@codeaurora.org
Owner:
mf...@codeaurora.org
Feb 16, 2011
For this bug a fix was already pushed for review: https://review.source.android.com/18715
Feb 16, 2011
Great.
Mar 27, 2011
(No comment was entered for this change.)
Status:
Submitted
Labels: FixedIn-2.1.7
May 31, 2011
(No comment was entered for this change.)
Status:
Released
|
|
| ► Sign in to add a comment |