| Issue 833: | Incorrect diff view for inserted blank line | |
| 5 people starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.1.6-rc1 What steps will reproduce the problem? 1. https://review.webmproject.org/#patch,sidebyside,1616,4,vp8/encoder/firstpass.c 2. toggle 'ignore whitespace' between all and none 3. observe the hunk at line 839 What is the expected output? What do you see instead? For this hunk: @@ -813,6 +835,7 @@ void vp8_first_pass(VP8_COMP *cpi) fps.coded_error = coded_error >> 8; weight = vp8_simple_weight(cpi->Source); + if (weight < 0.1) weight = 0.1; When viewed with ignore whitespace == None, it's shown as: @@ -813,6 +835,7 @@ void vp8_first_pass(VP8_COMP *cpi) fps.coded_error = coded_error >> 8; weight = vp8_simple_weight(cpi->Source); + if (weight < 0.1) if (weight < 0.1) weight = 0.1; With ignore whitespace != None, it's shown correctly.
Feb 7, 2011
#1
henri.ko...@gmail.com
May 20, 2011
Issue 842 has been merged into this issue.
May 20, 2011
Fixed in the "stable" branch of Gerrit and 2.1.7-rc2. Will be in 2.1.7 final.
Status:
Duplicate
Labels: FixedIn-2.1.7 Mergedinto: 853
May 20, 2011
Issue 939 has been merged into this issue. |
|
| ► Sign in to add a comment |