My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 805: Allow rejection of changes without Change-Id line should only effect refs/for/<branch>
4 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  May 2011


Sign in to add a comment
 
Reported by TheMole...@gmail.com, Dec 17, 2010
Affected Version: 2.1.6

The require change-Id project configuration option is a must have feature particularly with new users of Gerrit or Git. 

However the check currently applies globally to all pushes. 

In our system users always submit changes for review (and hence should have a change-Id), however when performing releases the build machine pushes directly to the branch and can't provide a change-id (nor should it as there isn't a review for the change).  Other people have problems if they need to push/pull changes in from upstream repositories which don't have a change-id. 

Therefore the check should ideallybe modelled as a permission allowing it to be configured based on users or as a quicker short term fix be only be applied to refs/for/**. 

Jan 3, 2011
#1 james.y....@gmail.com
Yeah, I noticed this problem too.

Does this patch do the trick? I think it will skip that check for changes pushed directly into a branch vs. one targeted for code review.
0001-Don-t-check-for-Signed-Off-By-and-Change-Id-lines-fo.patch
3.0 KB   View   Download
May 5, 2011
#2 TheMole...@gmail.com
Patch submitted awaiting review/merging:
https://review.source.android.com/#change,20653
May 15, 2011
#3 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.1.7
May 31, 2011
#4 sop@google.com
(No comment was entered for this change.)
Status: Released
Mar 22, 2012
Project Member #5 lscar...@gmail.com
Shawn, we are using v2.1.8 and it doesn't have this fix.

You closed it stating it's fixed in 2.1.7, but when we run a "git tag --contains" on the commit, we got:
v2.2.2
v2.2.2-rc0
v2.2.2-rc1
v2.2.2.1
v2.3-rc0

FixedIn actually = v2.2.2

Thanks,

Luciano.

Labels: -FixedIn-2.1.7 FixedIn-2.2.2
Mar 22, 2012
Project Member #6 lscar...@gmail.com
I updated the FixedIn label accordingly.
Luciano.
Sign in to add a comment

Powered by Google Project Hosting