| Issue 774: | Push was hanging, now reviews "stuck", can't view them to abandon/delete | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Affected Version: Had a large SQL file that I had changed (221 KB), the push would hang, ended up deleting that file and creating a new SQL file which pushed fine... I'm not familiar with git internals to know why it didn't like the changed file (which was 99% changed) but now I've got the old review stuck. Tailing the gerrit log didn't show anything of interest. We're on the latest Gerrit, 2.1.5
Nov 10, 2010
#1
jtur...@gmail.com
Nov 11, 2010
The web UI was hanging while computing the intraline difference information to show you which characters were changed. We know this code isn't efficient, its actually incredibly slow. A large-ish text file (221 KB) with a lot of lines changed (99%) is a great candidate for something that will cause this code to spin for a very, very long time.
Nov 11, 2010
(No comment was entered for this change.)
Status:
Duplicate
Mergedinto: 487
Nov 11, 2010
Should it also hang the push via command line though, so that the git push review "never" returns either? Or is the web UI doing some work even when you're pushing for caching/informational purposes? |
|
| ► Sign in to add a comment |