My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 739: Define and configure voting categories per project (or ref)
11 people starred this issue and may be notified of changes. Back to list
Status:  Submitted
Owner:  ----
Closed:  Apr 2013


Sign in to add a comment
 
Reported by sb...@codeaurora.org, Sep 28, 2010
It would be nice to have something like an acked-by button. Something like a +1/2 option?

Sometimes I want to ack a patch, but don't want an approver to immediately come by and submit the change without someone else more knowledgeable looking at it and giving it a +1 first. This way I can tell if I've acked it by looking at my dashboard and so can others I work with thus clearing up my dashboard a bit so I can focus on the incoming stuff.

Basically I want finer grained values since my workflow has approvers who are not technically involved in the code, reviewers who are technically involved and should +1 if they are the maintaining the code, and other reviewers who are affected by the change but not maintaining the code. The latter being where an acked by button could be very useful.
Sep 28, 2010
#1 nas...@chromium.org
I think we could get this with arbitrary labels and customizable dashboards, two things we're actively working on already.
Blockedon: 287 640
Sep 30, 2010
Project Member #2 edwin.ke...@gmail.com
Not sure if I fully understand your use case, but if you want finer grained values for the voting you might extend the voting range for an existing category or even introduce new voting categories. How this can be done is explained in the Access Control documentation [1] (just scroll to the very end and find the section 'Your Category Here'). Please note that changes to categories and their values are global and have effect on all projects hosted in Gerrit.

[1] https://review.source.android.com/Documentation/access-control.html#categories
Sep 30, 2010
#3 sb...@codeaurora.org
That looks like what I want. We could have the reviewers who are not technically involved in the code +1 in their own column allowing the change to be submitted. I could then use my +1 without fear of the change being submitted without further review. The only problem there is what you say, it's global to all projects. I think we have other projects that don't need nor want this fine grained voting so it will be hard to push this on all of them.
Sep 30, 2010
Project Member #4 edwin.ke...@gmail.com
Maybe we can redefine this issue to ask for a way to define and configure voting categories per project?
May 20, 2011
Project Member #5 nas...@grainawi.org
Blocked on the prolog engine support.
Summary: Define and configure voting categories per project (or ref)
Status: Accepted
Blockedon: 971
Jun 20, 2012
#7 marcin.c...@gmail.com
When I read original description of this issue I think this is a problem because of small bug, or a design issue.

A change displayed in "My changes" remains bolded even if you sent a 0-rated CRVW review. You have to send at least a -1/+1 CRVW review to actually see the change displayed normally again. 

This is probably becase zero-rated CRVW reviews are being silently added when inviting other reviewers. This feature is called "dummyApproval" in gerrit-server/src/main/java/com/google/gerrit/server/patch/AddReviewer.java.

If this is done some other way, zero-rated CRVW's could easily dismiss the "please review me" marking on the "My changes" screen.
Apr 10, 2013
Project Member #8 edwin.ke...@gmail.com
With 2.6 there is now support to define labels per project in the project.config file.
Status: Submitted
Labels: FixedIn-2.6
Blockedon: -gerrit:287 -gerrit:640 -gerrit:971 gerrit:287 gerrit:640 gerrit:971
Sign in to add a comment

Powered by Google Project Hosting