My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 738: Want to be able to give post-submit +- rating to a patch
3 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----

Blocked on:
issue 287


Sign in to add a comment
 
Reported by danf...@google.com, Sep 27, 2010
Affected Version: 2.1.5-83-gdb3be25

What steps will reproduce the problem?
1. Someone creates a change and submits it.
2. View the change.
3. Select "Review" on the submitted patchset.

What is the expected output? What do you see instead?
Expected: Ability to indicate +1, +2, etc.
Actual: No rating selections are available.

Please provide any additional information below.

Sometimes, one needs to submit a change before proper reviews can take place. In such cases, it would be good if, when a review finally happens, the results could be indicated in the same way that one can in a pre-submit review. Right now, we resort to adding comments that amount to the same thing, but then it doesn't show up in the convenient approval matrix UI, and it's not as easily audited in general.

Thanks for your consideration.
May 19, 2011
Project Member #1 nas...@grainawi.org
Talking about this it sounds like we'll support this via a Change label that can be applied post-submit and then implement a nagger and similar features. Need the label features first.
Status: Accepted
Labels: -Type-Bug Type-Feature
Blockedon: 287
Jun 12, 2013
#2 a...@stalecoffee.org
To add to this - I'm using Gerrit as part of a Continuous Delivery system. It would be awesome to be able to set up labels that correspond to the different stages a change is going through post merge, and have comments come in updating whether the change has passed those stages. So supporting this for custom labels would be awesome. As an example of a comment I'm posting today via the API, which is what led me to this request:

{ "message": "Finished release +1", "labels": {"Released": "+1"}, "notify": "OWNER_REVIEWERS"}

Where, obviously, "Released" is a custom label.
Sign in to add a comment

Powered by Google Project Hosting