My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 733: Include previous approvals in the approvals table
6 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


Sign in to add a comment
 
Reported by jessewil...@google.com, Sep 17, 2010
On my team we occasionally +2 our own patch sets if they've already received a +2 review. Usually this happens when the code's author is asked to make a trivial change (whitespace etc.) before submit.

When reviewing such a change in gerrit, it's not obvious at a glance whether a change ever received a +2. You have to read through the comments.

I'd like it if gerrit included the history of +2s and other grades in the overview table. I've attached a screenshot to make this concrete, although I don't really care too much how it looks in the UI.
gerrit-mockup.png
13.7 KB   View   Download
Sep 17, 2010
#1 jessewil...@google.com
An alternative layout would keep one column, but include a greyed-out checkmark with the patch set that it applies to:

  Reviewer         Code Review
  Brian Carlstrom  ✓
  Elliott Hughes   ✓ (PS2)
  Jesse Wilson
Sep 27, 2010
#2 danf...@google.com
Related to this, the approvals end up getting appended to the commit email, and it would be nice if the prior approvals show up there as well, for the same reasons.
May 20, 2011
Project Member #3 nas...@grainawi.org
(No comment was entered for this change.)
Status: Accepted
Sign in to add a comment

Powered by Google Project Hosting