My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 725: change summary of a reverted change is useless
2 people starred this issue and may be notified of changes. Back to list
Status:  Duplicate
Merged:  issue 1703
Owner:  ----
Closed:  Jan 2013


Sign in to add a comment
 
Reported by rgreenw...@google.com, Sep 9, 2010
If I make a change adding a line to a file, wait a year and then revert the change what I'd like to see in reviewing the revert change is the file in its current state on the left (with my added line from a year ago) and on the right the resulting file with my line removed.  What the current gerrit view seems to show is the diff from the version before my original change (a year ago) and the version after my change.  It's showing me everyone else's change rather than mine and that's pretty useless unless I know the contents of all those changes.
Sep 15, 2010
#1 sop@google.com
How do we know its a revert?

Are you expecting us to scrape the commit message for
the optional text segment that inserts that says:

  This reverts commit BLAHBLAHBLAH

?  Because the user could tweak that on us.

Status: AwaitingInformation
Sep 15, 2010
#2 rgreenw...@google.com
Nevermind - you can close the bug.
Mar 9, 2012
#3 ferri...@chromium.org
Offhand, the revert message really should include a new ChangeId, and preferably reference the ChangeId of what was reverted (if known from the sha1 being reverted)....
Jan 4, 2013
Project Member #4 edwin.ke...@gmail.com
[1] makes sure that a new Change-Id is included in the revert commit. Further improvements for revert are discussed in issue 1703.

[1] https://gerrit-review.googlesource.com/36614
Status: Duplicate
Mergedinto: 1703
Sign in to add a comment

Powered by Google Project Hosting