| Issue 72: | Make review comments standout more | |
| Back to list |
Reported by Wink Saville <wink@saville.com> on Wed Feb 11 14:54:54 PST 2009 Source: JIRA GERRIT-72 I'd like review comments to standout more on the side by side diff so when using the browser scroll bar to scroll through the source I'd like to more easily identify the review comments from the code.
Sep 24, 2009
#1
code-rev...@gtempaccount.com
Sep 24, 2009
Comment by Shawn Pearce <sop@google.com> on Fri Feb 13 08:06:44 PST 2009 From Wink in an email: > > Maybe make the light grey lines around the text, the dark grey triangle and > the area where the line numbers are could be some nice green color. > Signifying the comments are good:)
Sep 24, 2009
Comment by Shawn Pearce <sop@google.com> on Fri Feb 13 11:02:18 PST 2009 http://review.source.android.com/8881
Sep 24, 2009
Update by Shawn Pearce <sop@google.com> on Fri Feb 13 11:02:18 PST 2009 Fixed in version 2.0.3.
Status:
Fixed
Sep 24, 2009
Comment by Shawn Pearce <sop@google.com> on Fri Feb 13 11:06:15 PST 2009 You may need to force reload to get the new CSS rules, but see for example: http://review.source.android.com/Gerrit#patch,sidebyside,8851,1,src/main/java/com/google/gerrit/client/changes/ApprovalTable.java
Sep 24, 2009
Comment by Wink Saville <wink@saville.com> on Fri Feb 13 17:59:34 PST 2009 Looks great, thanks!
Sep 25, 2009
(No comment was entered for this change.)
Labels:
FixedIn-2.0.3
Oct 25, 2012
(No comment was entered for this change.)
Status:
Released
|
|
| ► Sign in to add a comment |