| Issue 719: | Gerrit spams reviewers of abandoned changes as they are merged/pushed later bypassing code review | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.1.5 What steps will reproduce the problem? 1. Make a change on a repository and abandon it. 2. Make a merge commit (locally) merging the commit that was abandoned at the previous step and some other branch in the same repository. 3. Push the merge commit from the previous step to a branch in the repository. What is the expected output? What do you see instead? Should push it to that branch and nothing else should happen. Instead Gerrit somehow figures out that the abandoned commit is being merged in into some other branch of the same repository so it adds a (automated) comment about that to the (abandoned) change of that commit which triggers sending mails to the reviewers on that change. I'm not sure what this feature (tracking changes as being merged/pushed to other branches bypassing code review) helps with but it seems to be wrong to be spamming people if they are only listed on an abandoned change for that commit on the same repository. Feel free to reject the bug if this is intentional as I have configured now that repository to not accept code reviews (it was a mistake, that's why the review got abandoned) and in order to just stop the current spam I will try to remove the reviewers from that abandoned change. Please provide any additional information below. In my case, the steps above aren't 100% exact as what happened but I believe they would reproduce the issue. The exact steps in my case are that the abandoned commit was later pushed (with code review) to a different repository and got submitted there. Then a tool that we run picked it up, made a merge of it with some other branch and pushed (bypassing code review) to the first repository. So when you search by the Change-Id you find both entries with Gerrit (the one abandoned in the first repository and the one submitted in the second) but I don't think that matters.
Sep 15, 2010
#1
sop@google.com
Status:
WontFix
|
|
| ► Sign in to add a comment |