My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 711: Add 0 to R column in dashboard
1 person starred this issue and may be notified of changes. Back to list
Status:  AwaitingInformation
Owner:  ----


Sign in to add a comment
 
Reported by w...@saville.com, Sep 3, 2010
Currently the Review column in the dashboard doesn't change when the comment is a "0". It would be nice that the 0 would be displayed and I'd like the change not be "bold".

-- Wink
Sep 3, 2010
#1 sop@google.com
Harder to implement than it sounds.

The way we show you a change is to have a 0 score already
stored for you in the database.  We bold the change when
the score is 0, as that implies you haven't scored it yet.

We unbold the change when you score it.  I think the Android
team is too polite here.  You guys use 0 to mean "fix up some
stuff before submit".  Gerrit / JGit / EGit use -1 to mean
"there's stuff we'd like to you fix" and -2 to mean "heck no
that is so buggy your computer will explode".

IMHO, 0 means you have no opinion at all on a change.  If you
would be OK with it submitting, +1 it.  If you'd like to see
something fixed, -1 it.  If you feel extremely one way or the
other, +2 or -2 it.  That's why its wider range than -1..1.
Status: AwaitingInformation
Sep 3, 2010
#2 w...@saville.com
I rarely/never use -1 where as I assume the other projects rarely/never use
0, here is how I interpret the values:

+2 = ready to go
+1 = is same as +2 but I can't or don't choose to +2.
 0 = Some comments but will likely +1 or +2
-1 = Can't submit in current state, but maybe can if comments addressed
-2 = Less likely to be submittable.

Couldn't a value other than 0 be the "initial" value so you
can differentiate between reviewed and not?
Sign in to add a comment

Powered by Google Project Hosting