My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 71: Leave approval bits alone if replacement patch is virtually identical
31 people starred this issue and may be notified of changes. Back to list
Status:  Submitted
Owner:  ----
Closed:  Dec 2013


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Brian Swetland <swetland@android.com> on Wed Feb 11 07:26:53 PST 2009
Source: JIRA GERRIT-71
Affected Version: 2.0.3

If someone submits an update to a patch, and the patch signature (or
whatever they call the sha1 of the whitespace,etc stripped patch)
matches, could we not flip off the verified/approved bits?

This might be a useful incremental step on the road toward not having to
re-upload/re-review if the head of the tree moves before you're
reviewed.
Sep 24, 2009
#1 sop+code@google.com
(No comment was entered for this change.)
Status: Accepted
Owner: ---
Sep 24, 2009
#2 sop+code@google.com
(No comment was entered for this change.)
Cc: swetl...@android.com
Sep 30, 2009
#3 sop+code@google.com
(No comment was entered for this change.)
Owner: nas...@codeaurora.org
Feb 4, 2010
#4 nas...@chromium.org
I don't really plan on working on this anytime soon, so it's up for grabs again.

For anyone who does decide to pick this up, I think the work required is:
1) JGit needs to learn how to generate a patch-id
2) Gerrit needs to have the logic added to do the correct thing with said patch-id

If someone does #1, I'll try to jump back in and do #2...
Owner: ---
Labels: Component-JGit
May 6, 2010
#5 nas...@chromium.org
Done via a hook, so I'll leave this open for now.
http://android.git.kernel.org/?
p=tools/gerrit.git;a=commit;h=592c8f5c8fd175f81bb392c60b6bb1ff89385679
Apr 28, 2011
#6 nas...@chromium.org
 Issue 921  has been merged into this issue.
Feb 4, 2013
#7 oswald.b...@gmx.de
i added some more or less useful comments in  Issue 985  (please merge the issue here).
Dec 16, 2013
Project Member #8 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/#/c/49872/
Status: Submitted
Cc: -notbrian...@gmail.com
Labels: -Component-JGit FixedIn-2.9
May 15, 2014
Project Member #9 edwin.ke...@gmail.com
(No comment was entered for this change.)
Labels: -FixedIn-2.9 FixedIn-2.8
Jun 23, 2014
Project Member #10 David.Os...@gmail.com
 Issue 985  has been merged into this issue.
Sign in to add a comment

Powered by Google Project Hosting