My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 691: Hitting "next page" keyboard shortcut when viewing the last file should take me to the overview
3 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Aug 2010


Sign in to add a comment
 
Reported by jessewil...@google.com, Aug 26, 2010
I love gerrit's keyboard shortcuts.

When reviewing a change, I use "]" to navigate through the files. When I reach the last file, I hit the "]" key because I don't realize I'm on the last file! And then I sit and stare at my screen for ten seconds, hoping that it will change to the next file. It doesn't do anything, and eventually I'll realize this and hit 'u' to go to the overview page.

Mondrian implements it this way and that works quite nicely. It also handles the symmetric case when navigating 'previous' from the first file.
Aug 26, 2010
#1 sop@google.com
Great idea.  We'll try to get it into the next release, I think
this should be a quick change.
Status: Accepted
Labels: Milestone-2.1.6
Aug 28, 2010
#2 sop@google.com
Fixed in Ie93b39c5ebadea481a5f20b64109fff5b635626b
Status: Submitted
Labels: -Milestone-2.1.6 FixedIn-2.1.6
Dec 15, 2010
#3 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting