My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 681: Default reviewer
59 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


Sign in to add a comment
 
Reported by antony.s...@gmail.com, Aug 23, 2010
Enable admin to set default reviewer for a given project.

This allows the person who always reviews everything to be safely view "my changes" instead of having to check the "not so nice" "all changes" view.
Aug 24, 2010
#1 nas...@chromium.org
Martin was planning on allowing this as part of the reviewer suggestion work.
Status: Accepted
Owner: mf...@codeaurora.org
Labels: -Type-Bug Type-Feature
Nov 11, 2010
#2 german.otero@gmail.com
It would be great if the owner of a project, can set the reviewers for a user in that project.
Because right now, the only way to do that is on each developer repository, in the .git/config. And this file is not in the "repository". 
If we can configure that in gerrit it's going to be awesome!.
Dec 9, 2010
#3 di...@google.com
I need this feature per branch :)
Apr 11, 2011
#4 nas...@chromium.org
(No comment was entered for this change.)
Owner: ---
Jul 30, 2011
#5 ericande...@gmail.com
Unassigned changes would also work well here under "All"
Jan 17, 2013
Project Member #6 edwin.ke...@gmail.com
 Issue 1763  has been merged into this issue.
Jan 17, 2013
#7 mtw...@gmail.com
This ticket has been open for a while, could there be a suggestion in the meantime to do this as a trigger to do a backend sql change on every push request?
Jan 23, 2013
#9 lash...@gmail.com
We fix this issue by hooks.
Each developer has a default reviewer. 
After change created, there is a notify mail to default reviewer.
Apr 3, 2013
#10 jan.opa...@gmail.com
Is this feature still needed given the possibility of defining notifications per project/branch (https://gerrit-review.googlesource.com/Documentation/user-notify.html) and Watched Projects?
May 13, 2013
#11 l13uw3hu...@gmail.com
Preferably: yes.
I work with many repositories, and review changes from different people from other departments as well, and I do not look at the watched projects. Personally, I mostly (>95%) look at all changes in my incoming review list
May 14, 2013
#12 jaykes...@gmail.com
Workaround: this can be done via a set-reviewers on each change pushed to refs/for, per repo, per branch, per file.
I did it using the Jenkins Gerrit Plugin.

May 14, 2013
#13 andrey.k...@gmail.com
Having default reviewers per project (or even per branch) is pretty limited approach. While it may cover basic needs of simple projects it still can be useless (or even annoying) for more complicated projects or projects with relatively large amount of contributors or project with specific workflows.

I'll try to explain. Imagine a complex project with 6-10+ developers working on it. There are frontend, backend, API developers, ... and basically different people take care of different components of the project. Team established that 2 reviewers is optimal for each review (less is not enough whereas 3+ is inefficient since distracts too many people + takes more time to pass a review). When new changeset arrives and say affects only API code we want API guru + backend developer be assigned as reviewers. We don't want to bother other people (frontend devels for instance). How to achieve this? Another requirement might be "if author X uploads changeset for project A then the reviewer must be Y however if Z uploads changeset for project A then reviewer must be X"

Currently we use home-grown script (which is triggered by patchset-created hook) + special rules in .git/description file. Rules describe how to assign default reviewers on the basis of 2 criterias:

1) who is an author of the change; 
2) which files were actually modified;

==
review: author=peter; reviewer=apist,bigboy; path=lib/api/.+;
review: author=bob; reviewer=suzy,ann; path=doc/.*;
review: author=*; reviewer=egghead; path=.+;
==

when change is uploaded for review script tries each modified/added/deleted file against a set of rules (first match wins) and so in the end it collects a full set of relevant reviewers that must approve change before submit. This solution is not ideal however it provides fine-grained and flexible control of reviewers assignment.

I hope that the example above illustrates expectations of people who want to see more flexible solution for automatic reviewers assignment.


 

Sep 16, 2013
#14 l13uw3hu...@gmail.com
Andrey, any chance on sharing your script? It may help others...
Oct 31, 2014
#15 alex.car...@gmail.com
I would be really interested in seeing how the config file looks like
Jun 24, 2015
#16 jordansq...@yahoo.com
any traction on this issue?
Sign in to add a comment

Powered by Google Project Hosting