My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 675: Gerrit can generate too long error comments that crash Firefox
2 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by di...@google.com, Aug 20, 2010
Affected Version: 2.1.4

What steps will reproduce the problem?
1. Have 2 gerrit repositories, one based on 2.6.33 and one on 2.6.34. 
2. Make the 2.6.33 one use Git's objects alternates pointing to the 2.6.34 one.
3. Push a branch based on 2.6.34 to a branch of the 2.6.33 tree.
4. Review the change and try to submit it

What is the expected output? What do you see instead?
It should display a truncated error comment about all the dependent commits that are not known as gerrit changes in that repository. Instead it makes a huge error message listing all the dependencies. This results in Firefox crashing when trying to load that change.

Please provide any additional information below.
This could also be considered a feature request tho I marked it as a bug since it wrongly creates too big output crashing browsers. Should instead probably display a part of it and provide some kind of link to display all if the user wants.
Sign in to add a comment

Powered by Google Project Hosting