My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 671: Syntax Coloring preference is not saved in Unified diff
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Mar 2012


Sign in to add a comment
 
Reported by chrisvau...@gmail.com, Aug 20, 2010
Affected Version: 2.1.4

What steps will reproduce the problem?
1.  diff a file using the unified view
2. click the checkbox for Syntax Coloring
3. click Update
4. Go back to Change view
5. diff another file in unified view
6. notice Syntax Coloring isn't checked

What is the expected output? What do you see instead?
I expected the Syntax Coloring checkbox to stay checked.  If you repeat the above steps with the Side By Side view the Syntax Coloring preference is saved.

Please provide any additional information below.


Aug 20, 2010
#1 sop@google.com
The issue here is we default syntax coloring to off in the unified
view.  Unfortunately the way we do that is by always overwriting your
preference to have syntax coloring.

The problem with syntax coloring in the unified view is it interferes
with the red lines mean delete and green lines mean added coloring
that is usually shown in a colored diff.
 
We could try to split this preference into two values, one for the
side-by-side view and one for the unified view.  Or we try to use a
background color on the lines instead of text color.

Status: AwaitingInformation
Labels: Milestone-2.1.5
Aug 20, 2010
#2 chrisvau...@gmail.com
I see. So it is being saved but loading the Unified view turns the setting off.  

It seems that the background color approach is already implemented.  Turning on Syntax Coloring in the Unified view changes the background color of the changed lines to red or green.  This functionality works well and is easy to see what has been deleted and what as been added.
Aug 21, 2010
#3 sop@google.com
Yes, apparently that is the case.

OK, I'll change the code to stop screwing with
the user's preference when they move to unified
and just honor it the same as side-by-side does.

Fixed in I3b7f21efb558429a7fd25158f2d62834c2ba56bf
Status: Fixed
Labels: -Milestone-2.1.5 FixedIn-2.1.5
Mar 27, 2012
#4 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting