| Issue 655: | configurable footers for cherry-pick submit mode | |
| 8 people starred this issue and may be notified of changes. | Back to list |
Some sites may want some or none of the footers that Gerrit currently inserts into the commit message when in cherry-pick submit mode. One way to improve this would be to pull the value of the footer name from a new column in approval_category_values for each category type. That way if you're using cherry-pick you can "configure" which approvals get put into the commit message (a NULL value would mean don't add the footer line).
Oct 11, 2010
#1
nas...@chromium.org
Owner:
mf...@codeaurora.org
Mar 7, 2011
putting the <e-mail> in the footer makes it easily available to spammers, it should be possible to just hide the <e-mail> while still adding the footer-line.
Apr 11, 2011
(No comment was entered for this change.)
Owner:
---
Aug 1, 2011
I implemented a patch for this feature. Project admins can choose which footers are added. All approval categories and Reviewed-on footer are included. Added footers can be limited to reviewers who gave maximum score for the category.
Nov 10, 2011
mika's implementation is live at http://codereview.qt-project.org/ . it seems to need some polish still (see https://bugreports.qt.nokia.com/browse/QTQAINFRA-348), but in general it works reasonably well. |
|
| ► Sign in to add a comment |