My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 642: Comments against earlier patch sets are not displaying unless you select the patch set
30 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by stad...@google.com, Jul 29, 2010
Version 2.1.4-rc1 @ review.source.android.com

Steps:

1.  open https://review.source.android.com/#patch,sidebyside,15830,5,src/com/android/email/service/EmnReceiver.java

2. Twist open Patch History

Expected:  I made comments in PS #2, so it should says "7 comments"

Actual:  No comments at all

Now check this out:  Click PS #2 in the "old version" column

Now it says "7 comments"

So the existence of comments is only being reported if you happen to select the correct patch set.


Makes it a lot harder to find old comments and respond to them.
Aug 13, 2010
Project Member #1 mf...@codeaurora.org
This looks like a problem related to the fact that the filename changed.  It seems to also mess up the diffs, see here:

https://review.source.android.com/#patch,sidebyside,15830,3,src/com/android/email/service/EmnReceiver.java


Oct 19, 2011
#2 phil.hord
Notes are only relevant to the PS they're made on, it seems.  Each new PS gets to start over at zero.  It does make the "Done" feature difficult to use.  :-(
Feb 18, 2014
#3 ThyMythos@googlemail.com
I'd also vote for promoting the comments to newer patch sets as long as they are not marked as "Done".
Sign in to add a comment

Powered by Google Project Hosting