My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 641: Exception running commit hooks
2 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Mar 2012


Sign in to add a comment
 
Reported by tisoftmedia, Jul 29, 2010
Affected Version:
2.1.4RC1

I have tried to add the trivial_rebase.py commit hook, but get the following exception:

[2010-07-29 11:24:06,877] ERROR com.google.gerrit.common.ChangeHookRunner : Unexpected error during hook execution
java.lang.NullPointerException
	at java.lang.ProcessBuilder.start(ProcessBuilder.java:442)
	at com.google.gerrit.common.ChangeHookRunner$1.run(ChangeHookRunner.java:404)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:98)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:207)
	at com.google.gerrit.server.git.WorkQueue$Task.run(WorkQueue.java:324)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)

Aug 9, 2010
#1 denisn.k...@gmail.com
I ran into the similar issue with the latest released version (2.1.4). 
The problem appears when gerrit executes patchsetCreatedHook. Some of the parameters passed into the ProcessBuilder are evaluated to null that, in turn, causes NPE. I suspect the problem is evaluating --uploader parameter (just my assumption).

[2010-08-10 01:14:22,166] ERROR com.google.gerrit.common.ChangeHookRunner : Unexpected error during hook execution
java.lang.NullPointerException
        at java.lang.ProcessBuilder.start(ProcessBuilder.java:441)
        at com.google.gerrit.common.ChangeHookRunner$1.run(ChangeHookRunner.java:404)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
        at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
        at java.util.concurrent.FutureTask.run(FutureTask.java:138)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:98)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:207)
        at com.google.gerrit.server.git.WorkQueue$Task.run(WorkQueue.java:324)
        at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:885)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:907)
        at java.lang.Thread.run(Thread.java:619)
Aug 18, 2010
#2 sop@google.com
This is being caused by the changeUrl coming
up null in the SSH context, because there is
no gerrit.canonicalWebUrl set in the server's
configuration file.
Status: Accepted
Labels: -Priority-Minor Priority-Critical Milestone-2.1.5
Aug 19, 2010
#3 sop@google.com
Fixed by Ib26ec8759e0090aadfc815c17fe7db0f299c640e
Status: Fixed
Labels: -Milestone-2.1.5 FixedIn-2.1.4.1
Aug 19, 2010
#4 sop@google.com
(No comment was entered for this change.)
Labels: -FixedIn-2.1.4.1 FixedIn-2.1.5
Mar 27, 2012
#5 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting