My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 64: Export approval data as a Git note when a change is merged
6 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  May 2011


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Mon Feb 09 08:05:38 PST 2009
Source: JIRA GERRIT-64
Affected Version: 2.0.3

Git 1.6.2 will have support for notes, which can be viewed inline as part of
the "git log" output.

Gerrit should export all approval data after a change has been accepted and
include it as a note for the commit, so clients can fetch the notes ref from
the project repository and have the information locally displayed whenever
"git log" is used.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Mon Feb 16 08:57:47 PST 2009

Git 1.6.2 will *NOT* have notes support.  There is still debate about how the
feature should be implemented so the code was pulled from the 1.6.2 release.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Mon Feb 16 08:58:00 PST 2009
Labels: -Priority-Major Priority-Trivial
Sep 24, 2009
#3 sop+code@google.com
(No comment was entered for this change.)
Status: Accepted
Owner: ---
Labels: -Priority-Trivial Priority-Minor
Dec 3, 2009
#4 sop@google.com
Git 1.6.6 will have notes.  We should start exporting a compatible notes tree.
Mar 10, 2010
#5 di...@google.com
Besides the issue of possibly having Gerrit put some metadata into git notes there is 
also the issue of being able to push notes to Gerrit. If you prefer I can open a 
separate feature request for that (tried pushing local "refs/notes/commits" to remote 
same path and of course it was rejected).
Mar 10, 2010
#6 shawn.pe...@gmail.com
To push notes, you need Gerrit 2.1.2-rc* and grant yourself the
Push Branch permission with refs/* or refs/notes/* as the ref
name in the access right.  (Prior to 2.1.2 RCs we rejected any
push outside of the refs/heads/ namespace.)
May 18, 2011
#7 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.1.7
May 31, 2011
#8 sop@google.com
(No comment was entered for this change.)
Status: Released
Oct 8, 2012
#10 g.nir...@gmail.com
After pushing the git-Notes to Gerrit, how can we view that on Gerrit server.. Both through command-line and GUI...
Sign in to add a comment

Powered by Google Project Hosting